Dialogic 1.x: Auto advance gets stuck

[catpieyum]

When calling

Dialogic.auto_advance_on(true)

after the typewriter effect has finished (meaning when the icon that shows you can progress shows up), auto advance gets stuck and doesn't advance to the next event. It only advances if it gets called while the typewriter effect is happening.

To Reproduce
Steps to reproduce the behavior:

1. Make an input called dialogic_auto bound to any key
2. Write the code bellow

func _input(event):
    if event.is_action_pressed("dialogic_auto"):
        Dialogic.auto_advance_on(true)

3. Run the game
4. Press the dialogic_auto key while the typewriter effect is happening

Expected behavior
The auto advance should not get stuck and continue its function when called at any moment.

System:

• OS: Windows 10
• Godot Version: v3.5.2.stable.official.170ba337a
• Dialogic Version: 1.5

[Jowan-Spooner]

Thank you for the report! This is an interesting problem.
Currently when the text finishes revealing it checks whether autoadvance is on and if so it starts a timer (which will activate the advance). So if you enable advance later the check has already been made.

The question is what to do when autoadvance is activated later on: should it start the timer at that point or consider how much time has already passed?

E.g. autoadvance time is set to 2 seconds.
Three seconds after the text has finished autoadvance get's toggled on:

• should it instantly advance
• or wait another 2 seconds?

[Jowan-Spooner]

Oh goddamnit excuse my stupidity. This is about 1.5 and I was talking about 2.x. My bad. Can't help you with 1.5 stuff though, maybe @zaknafean can.