Handle quotes while building upsert query

Author: mangalaman93

dgraph/cmd/alpha/upsert_test.go

@@ -2998,3 +2998,23 @@ func TestLargeStringIndex(t *testing.T) {
 	require.Contains(t, dqlSchema,
 		`{"predicate":"name_term","type":"string","index":true,"tokenizer":["term"]}`)
 }
+
+func TestStringWithQuote(t *testing.T) {
+	require.NoError(t, dropAll())
+	require.NoError(t, alterSchemaWithRetry(`name: string @unique @index(exact) .`))
+	mu := `{ set { <0x01> <name> "\"problem\" is the quotes (json)" . } }`
+	require.NoError(t, runMutation(mu))
+
+	var data struct {
+		Data struct {
+			Q []struct {
+				Name string `json:"name"`
+			} `json:"q"`
+		} `json:"data"`
+	}
+	q := `{ q(func: has(name)) { name } }`
+	res, _, err := queryWithTs(queryInp{body: q, typ: "application/dql"})
+	require.NoError(t, err)
+	require.NoError(t, json.Unmarshal([]byte(res), &data))
+	require.Equal(t, `"problem" is the quotes (json)`, data.Data.Q[0].Name)
+}

edgraph/server.go

@@ -1746,8 +1746,8 @@ func addQueryIfUnique(qctx context.Context, qc *queryContext) error {
 			// in the mutation, then we reject the mutation.
 
 			if !strings.HasPrefix(pred.ObjectId, "val(") {
-				query := fmt.Sprintf(`%v as var(func: eq(%v,"%v"))`, queryVar, predicateName,
-					dql.TypeValFrom(pred.ObjectValue).Value)
+				val := strconv.Quote(fmt.Sprintf("%v", dql.TypeValFrom(pred.ObjectValue).Value))
+				query := fmt.Sprintf(`%v as var(func: eq(%v,"%v"))`, queryVar, predicateName, val[1:len(val)-1])
 				if _, err := buildQuery.WriteString(query); err != nil {
 					return errors.Wrapf(err, "error while writing string")
 				}