Merge pull request danielgerlag#161 from Kahbazi/remove_reflection

Remove reflection for creating Data

Author: danielgerlag

src/WorkflowCore/Interface/IWorkflowController.cs

@@ -9,8 +9,8 @@ public interface IWorkflowController
     {
         Task<string> StartWorkflow(string workflowId, object data = null, string reference=null);
         Task<string> StartWorkflow(string workflowId, int? version, object data = null, string reference=null);
-        Task<string> StartWorkflow<TData>(string workflowId, TData data = null, string reference=null) where TData : class;
-        Task<string> StartWorkflow<TData>(string workflowId, int? version, TData data = null, string reference=null) where TData : class;
+        Task<string> StartWorkflow<TData>(string workflowId, TData data = null, string reference=null) where TData : class, new();
+        Task<string> StartWorkflow<TData>(string workflowId, int? version, TData data = null, string reference=null) where TData : class, new();
 
         Task PublishEvent(string eventName, string eventKey, object eventData, DateTime? effectiveDate = null);
         void RegisterWorkflow<TWorkflow>() where TWorkflow : IWorkflow, new();

src/WorkflowCore/Services/WorkflowController.cs

@@ -18,7 +18,7 @@ public class WorkflowController : IWorkflowController
         private readonly IQueueProvider _queueProvider;
         private readonly IExecutionPointerFactory _pointerFactory;
         private readonly ILogger _logger;
-        
+
         public WorkflowController(IPersistenceProvider persistenceStore, IDistributedLockProvider lockProvider, IWorkflowRegistry registry, IQueueProvider queueProvider, IExecutionPointerFactory pointerFactory, ILoggerFactory loggerFactory)
         {
             _persistenceStore = persistenceStore;
@@ -40,15 +40,15 @@ public Task<string> StartWorkflow(string workflowId, int? version, object data =
         }
 
         public Task<string> StartWorkflow<TData>(string workflowId, TData data = null, string reference=null) 
-            where TData : class
+            where TData : class, new()
         {
             return StartWorkflow<TData>(workflowId, null, data, reference);
         }
 
         public async Task<string> StartWorkflow<TData>(string workflowId, int? version, TData data = null, string reference=null)
-            where TData : class
+            where TData : class, new()
         {
-            
+
             var def = _registry.GetDefinition(workflowId, version);
             if (def == null)
             {
@@ -69,7 +69,7 @@ public async Task<string> StartWorkflow<TData>(string workflowId, int? version,
 
             if ((def.DataType != null) && (data == null))
             {
-                wf.Data = TypeExtensions.GetConstructor(def.DataType, new Type[] { }).Invoke(null);
+                wf.Data = new TData();
             }
 
             wf.ExecutionPointers.Add(_pointerFactory.BuildGenesisPointer(def));
@@ -102,7 +102,7 @@ public async Task<bool> SuspendWorkflow(string workflowId)
         {
             if (!await _lockProvider.AcquireLock(workflowId, new CancellationToken()))
                 return false;
-            
+
             try
             {
                 var wf = await _persistenceStore.GetWorkflowInstance(workflowId);
@@ -169,7 +169,7 @@ public async Task<bool> TerminateWorkflow(string workflowId)
                 await _lockProvider.ReleaseLock(workflowId);
             }
         }
-        
+
         public void RegisterWorkflow<TWorkflow>()
             where TWorkflow : IWorkflow, new()
         {

src/WorkflowCore/Services/WorkflowHost.cs

@@ -12,8 +12,8 @@
 namespace WorkflowCore.Services
 {
     public class WorkflowHost : IWorkflowHost, IDisposable
-    {                
-        protected bool _shutdown = true;        
+    {
+        protected bool _shutdown = true;
         protected readonly IServiceProvider _serviceProvider;
 
         private readonly IEnumerable<IBackgroundTask> _backgroundTasks;
@@ -54,14 +54,14 @@ public Task<string> StartWorkflow(string workflowId, int? version, object data =
         }
 
         public Task<string> StartWorkflow<TData>(string workflowId, TData data = null, string reference=null)
-            where TData : class
+            where TData : class, new()
         {
             return _workflowController.StartWorkflow<TData>(workflowId, null, data, reference);
         }
 
 
         public Task<string> StartWorkflow<TData>(string workflowId, int? version, TData data = null, string reference=null)
-            where TData : class
+            where TData : class, new()
         {
             return _workflowController.StartWorkflow(workflowId, version, data, reference);
         }
@@ -72,7 +72,7 @@ public Task PublishEvent(string eventName, string eventKey, object eventData, Da
         }
 
         public void Start()
-        {            
+        {
             _shutdown = false;
             PersistenceStore.EnsureStoreExists();
             QueueProvider.Start().Wait();
@@ -86,26 +86,26 @@ public void Start()
 
         public void Stop()
         {
-            _shutdown = true;            
-            
+            _shutdown = true;
+
             Logger.LogInformation("Stopping background tasks");
             foreach (var th in _backgroundTasks)
                 th.Stop();
-            
+
             Logger.LogInformation("Worker tasks stopped");
-            
+
             QueueProvider.Stop();
             LockProvider.Stop();
         }
-        
-        public void RegisterWorkflow<TWorkflow>() 
+
+        public void RegisterWorkflow<TWorkflow>()
             where TWorkflow : IWorkflow, new()
         {
             TWorkflow wf = new TWorkflow();
             Registry.RegisterWorkflow(wf);
         }
 
-        public void RegisterWorkflow<TWorkflow, TData>() 
+        public void RegisterWorkflow<TWorkflow, TData>()
             where TWorkflow : IWorkflow<TData>, new()
             where TData : new()
         {