Skip to content

Commit d1f35fb

Browse files
cmeerenTheAngryByrd
authored andcommitted
Replace all "Option<_>" annotations with "_ option"
1 parent 270ed55 commit d1f35fb

File tree

4 files changed

+75
-75
lines changed

4 files changed

+75
-75
lines changed

src/FsToolkit.ErrorHandling.JobResult/JobOptionCE.fs

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@ module JobOptionCE =
99

1010
type JobOptionBuilder() =
1111

12-
member __.Return (value: 'T) : Job<Option<_>> =
12+
member __.Return (value: 'T) : Job<_ option> =
1313
job.Return <| option.Return value
1414

1515
member __.ReturnFrom
16-
(jobResult: Job<Option<_>>)
17-
: Job<Option<_>> =
16+
(jobResult: Job<_ option>)
17+
: Job<_ option> =
1818
jobResult
1919

20-
member __.Zero () : Job<Option<_>> =
20+
member __.Zero () : Job<_ option> =
2121
job.Return <| option.Zero ()
2222

2323
member __.Bind
24-
(jobResult: Job<Option<_>>,
25-
binder: 'T -> Job<Option<_>>)
26-
: Job<Option<_>> =
24+
(jobResult: Job<_ option>,
25+
binder: 'T -> Job<_ option>)
26+
: Job<_ option> =
2727
job {
2828
let! result = jobResult
2929
match result with
@@ -32,61 +32,61 @@ module JobOptionCE =
3232
}
3333

3434
member this.Bind
35-
(taskResult: unit -> Task<Option<_>>,
36-
binder: 'T -> Job<Option<_>>)
37-
: Job<Option<_>> =
35+
(taskResult: unit -> Task<_ option>,
36+
binder: 'T -> Job<_ option>)
37+
: Job<_ option> =
3838
this.Bind(Job.fromTask taskResult, binder)
3939

4040
member __.Delay
41-
(generator: unit -> Job<Option<_>>)
42-
: Job<Option<_>> =
41+
(generator: unit -> Job<_ option>)
42+
: Job<_ option> =
4343
Job.delay generator
4444

4545
member this.Combine
46-
(computation1: Job<Option<_>>,
47-
computation2: Job<Option<_>>)
48-
: Job<Option<_>> =
46+
(computation1: Job<_ option>,
47+
computation2: Job<_ option>)
48+
: Job<_ option> =
4949
this.Bind(computation1, fun () -> computation2)
5050

5151
member __.TryWith
52-
(computation: Job<Option<_>>,
53-
handler: System.Exception -> Job<Option<_>>)
54-
: Job<Option<_>> =
52+
(computation: Job<_ option>,
53+
handler: System.Exception -> Job<_ option>)
54+
: Job<_ option> =
5555
Job.tryWith computation handler
5656

5757
member __.TryWith
58-
(computation: unit -> Job<Option<_>>,
59-
handler: System.Exception -> Job<Option<_>>)
60-
: Job<Option<_>> =
58+
(computation: unit -> Job<_ option>,
59+
handler: System.Exception -> Job<_ option>)
60+
: Job<_ option> =
6161
Job.tryWithDelay computation handler
6262

6363
member __.TryFinally
64-
(computation: Job<Option<_>>,
64+
(computation: Job<_ option>,
6565
compensation: unit -> unit)
66-
: Job<Option<_>> =
66+
: Job<_ option> =
6767
Job.tryFinallyFun computation compensation
6868

6969
member __.TryFinally
70-
(computation: unit -> Job<Option<_>>,
70+
(computation: unit -> Job<_ option>,
7171
compensation: unit -> unit)
72-
: Job<Option<_>> =
72+
: Job<_ option> =
7373
Job.tryFinallyFunDelay computation compensation
7474

7575
member __.Using
7676
(resource: 'T when 'T :> IDisposable,
77-
binder: 'T -> Job<Option<_>>)
78-
: Job<Option<_>> =
77+
binder: 'T -> Job<_ option>)
78+
: Job<_ option> =
7979
job.Using(resource, binder)
8080

8181
member this.While
82-
(guard: unit -> bool, computation: Job<Option<_>>)
83-
: Job<Option<_>> =
82+
(guard: unit -> bool, computation: Job<_ option>)
83+
: Job<_ option> =
8484
if not <| guard () then this.Zero ()
8585
else this.Bind(computation, fun () -> this.While (guard, computation))
8686

8787
member this.For
88-
(sequence: #seq<'T>, binder: 'T -> Job<Option<_>>)
89-
: Job<Option<_>> =
88+
(sequence: #seq<'T>, binder: 'T -> Job<_ option>)
89+
: Job<_ option> =
9090
this.Using(sequence.GetEnumerator (), fun enum ->
9191
this.While(enum.MoveNext,
9292
this.Delay(fun () -> binder enum.Current)))
@@ -96,17 +96,17 @@ module JobOptionCE =
9696
///
9797
/// See https://stackoverflow.com/questions/35286541/why-would-you-use-builder-source-in-a-custom-computation-expression-builder
9898
/// </summary>
99-
member inline _.Source(job : Job<Option<_>>) : Job<Option<_>> = job
99+
member inline _.Source(job : Job<_ option>) : Job<_ option> = job
100100

101101
/// <summary>
102102
/// Method lets us transform data types into our internal representation.
103103
/// </summary>
104-
member inline _.Source(async : Async<Option<_>>) : Job<Option<_>> = async |> Job.fromAsync
104+
member inline _.Source(async : Async<_ option>) : Job<_ option> = async |> Job.fromAsync
105105

106106
/// <summary>
107107
/// Method lets us transform data types into our internal representation.
108108
/// </summary>
109-
member inline _.Source(task : Task<Option<_>>) : Job<Option<_>> = task |> Job.awaitTask
109+
member inline _.Source(task : Task<_ option>) : Job<_ option> = task |> Job.awaitTask
110110

111111
let jobOption = JobOptionBuilder()
112112

@@ -124,7 +124,7 @@ module JobOptionCEExtensions =
124124
/// <summary>
125125
/// Method lets us transform data types into our internal representation.
126126
/// </summary>
127-
member inline __.Source(r: Option<'t>) = Job.singleton r
127+
member inline __.Source(r: 't option) = Job.singleton r
128128
/// <summary>
129129
/// Method lets us transform data types into our internal representation.
130130
/// </summary>

src/FsToolkit.ErrorHandling.TaskResult/TaskOptionCE.fs

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -12,61 +12,61 @@ module TaskOptionCE =
1212
member val SomeUnit = Some ()
1313

1414
member inline _.Return (value: 'T)
15-
: Ply<Option<_>> =
15+
: Ply<_ option> =
1616
uply.Return <| option.Return value
1717

1818
member inline _.ReturnFrom
19-
(taskResult: Task<Option<_>>)
20-
: Ply<Option<_>> =
19+
(taskResult: Task<_ option>)
20+
: Ply<_ option> =
2121
uply.ReturnFrom taskResult
2222

23-
member inline _.Zero () : Ply<Option<_>> =
23+
member inline _.Zero () : Ply<_ option> =
2424
uply.Return <| option.Zero()
2525

2626
member inline _.Bind
27-
(taskResult: Task<Option<_>>,
28-
binder: 'T -> Ply<Option<_>>)
29-
: Ply<Option<_>> =
27+
(taskResult: Task<_ option>,
28+
binder: 'T -> Ply<_ option>)
29+
: Ply<_ option> =
3030
let binder' r =
3131
match r with
3232
| Some x -> binder x
3333
| None -> uply.Return None
3434
uply.Bind(taskResult, binder')
3535

3636
member inline _.Delay
37-
(generator: unit -> Ply<Option<_>>) =
37+
(generator: unit -> Ply<_ option>) =
3838
uply.Delay(generator)
3939

4040
member inline _.Combine
41-
(computation1: Ply<Option<'T>>,
42-
computation2: unit -> Ply<Option<'U>>)
43-
: Ply<Option<'U>> = uply {
41+
(computation1: Ply<'T option>,
42+
computation2: unit -> Ply<'U option>)
43+
: Ply<'U option> = uply {
4444
match! computation1 with
4545
| None -> return None
4646
| Some _ -> return! computation2()
4747
}
4848

4949
member inline _.TryWith
50-
(computation: unit -> Ply<Option<_>>,
51-
handler: exn -> Ply<Option<_>>) :
52-
Ply<Option<_>> =
50+
(computation: unit -> Ply<_ option>,
51+
handler: exn -> Ply<_ option>) :
52+
Ply<_ option> =
5353
uply.TryWith(computation, handler)
5454

5555
member inline _.TryFinally
56-
(computation: unit -> Ply<Option<_>>,
56+
(computation: unit -> Ply<_ option>,
5757
compensation: unit -> unit)
58-
: Ply<Option<_>> =
58+
: Ply<_ option> =
5959
uply.TryFinally(computation, compensation)
6060

6161
member inline _.Using
6262
(resource: 'T when 'T :> IDisposable,
63-
binder: 'T -> Ply<Option<_>>)
64-
: Ply<Option<_>> =
63+
binder: 'T -> Ply<_ option>)
64+
: Ply<_ option> =
6565
uply.Using(resource, binder)
6666

6767
member _.While
68-
(guard: unit -> bool, computation: unit -> Ply<Option<'U>>)
69-
: Ply<Option<'U>> = uply {
68+
(guard: unit -> bool, computation: unit -> Ply<'U option>)
69+
: Ply<'U option> = uply {
7070
let mutable fin, result = false, None
7171
while not fin && guard() do
7272
match! computation() with
@@ -79,8 +79,8 @@ module TaskOptionCE =
7979
}
8080

8181
member _.For
82-
(sequence: #seq<'T>, binder: 'T -> Ply<Option<'U>>)
83-
: Ply<Option<'U>> = uply {
82+
(sequence: #seq<'T>, binder: 'T -> Ply<'U option>)
83+
: Ply<'U option> = uply {
8484
use enumerator = sequence.GetEnumerator()
8585
let mutable fin, result = false, None
8686
while not fin && enumerator.MoveNext() do
@@ -93,30 +93,30 @@ module TaskOptionCE =
9393
return result
9494
}
9595

96-
member inline this.BindReturn(x: Task<Option<'T>>, f) = this.Bind(x, fun x -> this.Return(f x))
97-
member inline _.MergeSources(t1: Task<Option<'T>>, t2: Task<Option<'T1>>) = TaskOption.zip t1 t2
96+
member inline this.BindReturn(x: Task<'T option>, f) = this.Bind(x, fun x -> this.Return(f x))
97+
member inline _.MergeSources(t1: Task<'T option>, t2: Task<'T1 option>) = TaskOption.zip t1 t2
9898
member inline _.Run(f : unit -> Ply<'m>) = task.Run f
9999

100100
/// <summary>
101101
/// Method lets us transform data types into our internal representation. This is the identity method to recognize the self type.
102102
/// See https://stackoverflow.com/questions/35286541/why-would-you-use-builder-source-in-a-custom-computation-expression-builder
103103
/// </summary>
104-
member inline _.Source(task : Task<Option<_>>) : Task<Option<_>> = task
104+
member inline _.Source(task : Task<_ option>) : Task<_ option> = task
105105

106106
/// <summary>
107107
/// Method lets us transform data types into our internal representation.
108108
/// </summary>
109-
member inline _.Source(t : ValueTask<Option<_>>) : Task<Option<_>> = task { return! t }
109+
member inline _.Source(t : ValueTask<_ option>) : Task<_ option> = task { return! t }
110110

111111
/// <summary>
112112
/// Method lets us transform data types into our internal representation.
113113
/// </summary>
114-
member inline _.Source(async : Async<Option<_>>) : Task<Option<_>> = async |> Async.StartAsTask
114+
member inline _.Source(async : Async<_ option>) : Task<_ option> = async |> Async.StartAsTask
115115

116116
/// <summary>
117117
/// Method lets us transform data types into our internal representation.
118118
/// </summary>
119-
member inline _.Source(p : Ply<Option<_>>) : Task<Option<_>> = task { return! p }
119+
member inline _.Source(p : Ply<_ option>) : Task<_ option> = task { return! p }
120120

121121
let taskOption = TaskOptionBuilder()
122122

@@ -134,7 +134,7 @@ module TaskOptionCEExtensions =
134134
/// <summary>
135135
/// Method lets us transform data types into our internal representation.
136136
/// </summary>
137-
member inline __.Source(r: Option<'t>) = Task.singleton r
137+
member inline __.Source(r: 't option) = Task.singleton r
138138

139139
/// <summary>
140140
/// Method lets us transform data types into our internal representation.

src/FsToolkit.ErrorHandling/OptionCE.fs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ module OptionCE =
88

99
member inline _.ReturnFrom(m: 'T option) = m
1010

11-
member inline _.Bind(m : Option<'a>, f: 'a -> Option<'b>) = Option.bind f m
11+
member inline _.Bind(m : 'a option, f: 'a -> 'b option) = Option.bind f m
1212

1313
// Could not get it to work solely with Source. In loop cases it would potentially match the #seq overload and ask for type annotation
14-
member this.Bind(m : 'a when 'a:null, f: 'a -> Option<'b>) = this.Bind(m |> Option.ofObj, f)
14+
member this.Bind(m : 'a when 'a:null, f: 'a -> 'b option) = this.Bind(m |> Option.ofObj, f)
1515

1616
member inline this.Zero() = this.Return ()
1717

1818
member inline _.Combine(m, f) = Option.bind f m
19-
member inline this.Combine(m1 : Option<_>, m2 : Option<_>) = this.Bind(m1 , fun () -> m2)
19+
member inline this.Combine(m1 : _ option, m2 : _ option) = this.Bind(m1 , fun () -> m2)
2020

2121
member inline _.Delay(f: unit -> _) = f
2222

@@ -31,21 +31,21 @@ module OptionCE =
3131
finally compensation()
3232

3333
member inline this.Using
34-
(resource: 'T when 'T :> IDisposable, binder) : Option<_>=
34+
(resource: 'T when 'T :> IDisposable, binder) : _ option=
3535
this.TryFinally (
3636
(fun () -> binder resource),
3737
(fun () -> if not <| obj.ReferenceEquals(resource, null) then resource.Dispose ())
3838
)
3939

4040
member this.While
41-
(guard: unit -> bool, generator: unit -> Option<_>)
42-
: Option<_> =
41+
(guard: unit -> bool, generator: unit -> _ option)
42+
: _ option =
4343
if not <| guard () then this.Zero ()
4444
else this.Bind(this.Run generator, fun () -> this.While (guard, generator))
4545

4646
member inline this.For
47-
(sequence: #seq<'T>, binder: 'T -> Option<_>)
48-
: Option<_> =
47+
(sequence: #seq<'T>, binder: 'T -> _ option)
48+
: _ option =
4949
this.Using(sequence.GetEnumerator (), fun enum ->
5050
this.While(enum.MoveNext,
5151
this.Delay(fun () -> binder enum.Current)))
@@ -59,7 +59,7 @@ module OptionCE =
5959
///
6060
/// See https://stackoverflow.com/questions/35286541/why-would-you-use-builder-source-in-a-custom-computation-expression-builder
6161
/// </summary>
62-
member inline _.Source(result : Option<_>) : Option<_> = result
62+
member inline _.Source(result : _ option) : _ option = result
6363

6464

6565
let option = OptionBuilder()
@@ -97,7 +97,7 @@ module OptionExtensions =
9797
// /// <summary>
9898
// /// Method lets us transform data types into our internal representation.
9999
// /// </summary>
100-
member inline _.Source(nullable : Nullable<'a>) : Option<'a> = nullable |> Option.ofNullable
100+
member inline _.Source(nullable : Nullable<'a>) : 'a option = nullable |> Option.ofNullable
101101

102102

103103

tests/FsToolkit.ErrorHandling.Tests/OptionCE.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ let makeDisposable () =
1515
with member this.Dispose() = () }
1616

1717

18-
// type Option<'a> = | Some of 'a | None
18+
// type 'a option = | Some of 'a | None
1919

2020
let ceTests =
2121
testList "CE Tests" [

0 commit comments

Comments
 (0)