Skip to content

Commit 368e6db

Browse files
committed
Update traverseResultA tests to verify ordering is correct
1 parent c7f94d6 commit 368e6db

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

tests/FsToolkit.ErrorHandling.JobResult.Tests/List.fs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ let traverseJobResultMTests =
2323

2424
testList "List.traverseJobResultM Tests" [
2525
testCase "traverseJobResultM with a list of valid data" <| fun _ ->
26-
let expected = [();();()]
26+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
2727
let actual =
2828
List.traverseJobResultM (notifyNewPostSuccess (PostId newPostId)) userIds
2929
Expect.hasJobOkValue expected actual
3030

31+
3132
testCase "traverseResultA with few invalid data" <| fun _ ->
3233
let expected = sprintf "error: %s" (userId1.ToString())
3334
let actual =
@@ -48,7 +49,7 @@ let traverseJobResultATests =
4849
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
4950
testList "List.traverseJobResultA Tests" [
5051
testCase "traverseJobResultA with a list of valid data" <| fun _ ->
51-
let expected = [();();();()]
52+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
5253
let actual =
5354
List.traverseJobResultA (notifyNewPostSuccess (PostId newPostId)) userIds
5455
Expect.hasJobOkValue expected actual
@@ -66,7 +67,7 @@ let sequenceJobResultMTests =
6667
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
6768
testList "List.sequenceJobResultM Tests" [
6869
testCase "sequenceJobResultM with a list of valid data" <| fun _ ->
69-
let expected = [();();();()]
70+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
7071
let actual =
7172
List.map (notifyNewPostSuccess (PostId newPostId)) userIds
7273
|> List.sequenceJobResultM
@@ -85,7 +86,7 @@ let sequenceJobResultATests =
8586
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
8687
testList "List.sequenceJobResultA Tests" [
8788
testCase "sequenceJobResultA with a list of valid data" <| fun _ ->
88-
let expected = [();();();()]
89+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
8990
let actual =
9091
List.map (notifyNewPostSuccess (PostId newPostId)) userIds
9192
|> List.sequenceJobResultA

tests/FsToolkit.ErrorHandling.TaskResult.Tests/List.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ let traverseTaskResultMTests =
2323

2424
testList "List.traverseTaskResultM Tests" [
2525
testCase "traverseTaskResultM with a list of valid data" <| fun _ ->
26-
let expected = [();();()]
26+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
2727
let actual =
2828
List.traverseTaskResultM (notifyNewPostSuccess (PostId newPostId)) userIds
2929
Expect.hasTaskOkValue expected actual
@@ -48,7 +48,7 @@ let traverseTaskResultATests =
4848
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
4949
testList "List.traverseTaskResultA Tests" [
5050
testCase "traverseTaskResultA with a list of valid data" <| fun _ ->
51-
let expected = [();();();()]
51+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
5252
let actual =
5353
List.traverseTaskResultA (notifyNewPostSuccess (PostId newPostId)) userIds
5454
Expect.hasTaskOkValue expected actual
@@ -66,7 +66,7 @@ let sequenceTaskResultMTests =
6666
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
6767
testList "List.sequenceTaskResultM Tests" [
6868
testCase "sequenceTaskResultM with a list of valid data" <| fun _ ->
69-
let expected = [();();();()]
69+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
7070
let actual =
7171
List.map (notifyNewPostSuccess (PostId newPostId)) userIds
7272
|> List.sequenceTaskResultM
@@ -85,7 +85,7 @@ let sequenceTaskResultATests =
8585
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
8686
testList "List.sequenceTaskResultA Tests" [
8787
testCase "sequenceTaskResultA with a list of valid data" <| fun _ ->
88-
let expected = [();();();()]
88+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
8989
let actual =
9090
List.map (notifyNewPostSuccess (PostId newPostId)) userIds
9191
|> List.sequenceTaskResultA

tests/FsToolkit.ErrorHandling.Tests/List.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ let traverseAsyncResultMTests =
118118

119119
testList "List.traverseAsyncResultM Tests" [
120120
testCaseAsync "traverseAsyncResultM with a list of valid data" <| async {
121-
let expected = [();();()]
121+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
122122
let actual =
123123
List.traverseAsyncResultM (notifyNewPostSuccess (PostId newPostId)) userIds
124124
do! Expect.hasAsyncOkValue expected actual
@@ -144,7 +144,7 @@ let traverseAsyncResultATests =
144144
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
145145
testList "List.traverseAsyncResultA Tests" [
146146
testCaseAsync "traverseAsyncResultA with a list of valid data" <| async {
147-
let expected = [();();();()]
147+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
148148
let actual =
149149
List.traverseAsyncResultA (notifyNewPostSuccess (PostId newPostId)) userIds
150150
do! Expect.hasAsyncOkValue expected actual
@@ -164,7 +164,7 @@ let sequenceAsyncResultMTests =
164164
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
165165
testList "List.sequenceAsyncResultM Tests" [
166166
testCaseAsync "sequenceAsyncResultM with a list of valid data" <| async {
167-
let expected = [();();();()]
167+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
168168
let actual =
169169
List.map (notifyNewPostSuccess (PostId newPostId)) userIds
170170
|> List.sequenceAsyncResultM
@@ -185,7 +185,7 @@ let sequenceAsyncResultATests =
185185
let userIds = List.map UserId [userId1;userId2;userId3;userId4]
186186
testList "List.sequenceAsyncResultA Tests" [
187187
testCaseAsync "sequenceAsyncResultA with a list of valid data" <| async {
188-
let expected = [();();();()]
188+
let expected = userIds |> List.map(fun (UserId user) -> (newPostId, user))
189189
let actual =
190190
List.map (notifyNewPostSuccess (PostId newPostId)) userIds
191191
|> List.sequenceAsyncResultA

tests/FsToolkit.ErrorHandling.Tests/SampleDomain.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ let createPostFailure (_ : CreatePostRequest) = async {
224224
}
225225

226226

227-
let notifyNewPostSuccess (PostId _) (UserId _) = async {
228-
return Ok ()
227+
let notifyNewPostSuccess (PostId post) (UserId user) = async {
228+
return Ok (post, user)
229229
}
230230

231231
let notifyNewPostFailure (PostId _) (UserId uId) = async {

0 commit comments

Comments
 (0)