Skip to content

Commit e4b4571

Browse files
committed
Factor gutter width/tag token width into a setting
1 parent 185a77b commit e4b4571

File tree

5 files changed

+17
-3
lines changed

5 files changed

+17
-3
lines changed

basicblock.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,18 @@ void DisassemblySettings::SetMaximumSymbolWidth(size_t width)
7272
}
7373

7474

75+
size_t DisassemblySettings::GetGutterWidth() const
76+
{
77+
return BNGetDisassemblyGutterWidth(m_object);
78+
}
79+
80+
81+
void DisassemblySettings::SetGutterWidth(size_t width)
82+
{
83+
BNSetDisassemblyGutterWidth(m_object, width);
84+
}
85+
86+
7587
DisassemblyTextLine::DisassemblyTextLine()
7688
{
7789
addr = 0;

binaryninjaapi.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2797,6 +2797,8 @@ __attribute__ ((format (printf, 1, 2)))
27972797
void SetWidth(size_t width);
27982798
size_t GetMaximumSymbolWidth() const;
27992799
void SetMaximumSymbolWidth(size_t width);
2800+
size_t GetGutterWidth() const;
2801+
void SetGutterWidth(size_t width);
28002802
};
28012803

28022804
class Function;

binaryninjacore.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@
7272

7373
#define BN_MAX_STRING_LENGTH 128
7474

75-
#define BN_TAG_TOKEN_WIDTH 5
76-
7775
#define LLVM_SVCS_CB_NOTE 0
7876
#define LLVM_SVCS_CB_WARNING 1
7977
#define LLVM_SVCS_CB_ERROR 2
@@ -3077,6 +3075,8 @@ __attribute__ ((format (printf, 1, 2)))
30773075
BINARYNINJACOREAPI void BNSetDisassemblyWidth(BNDisassemblySettings* settings, size_t width);
30783076
BINARYNINJACOREAPI size_t BNGetDisassemblyMaximumSymbolWidth(BNDisassemblySettings* settings);
30793077
BINARYNINJACOREAPI void BNSetDisassemblyMaximumSymbolWidth(BNDisassemblySettings* settings, size_t width);
3078+
BINARYNINJACOREAPI size_t BNGetDisassemblyGutterWidth(BNDisassemblySettings* settings);
3079+
BINARYNINJACOREAPI void BNSetDisassemblyGutterWidth(BNDisassemblySettings* settings, size_t width);
30803080

30813081
// Flow graphs
30823082
BINARYNINJACOREAPI BNFlowGraph* BNCreateFlowGraph();

ui/linearview.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
#define LINEAR_VIEW_UPDATE_CHECK_INTERVAL 200
1414
#define MAX_STRING_TYPE_LENGTH 1048576
15-
#define EDGE_GUTTER_WIDTH 5
1615

1716
struct BINARYNINJAUIAPI LinearViewCursorPosition: public BinaryNinja::LinearDisassemblyPosition
1817
{

ui/tokenizedtextview.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class BINARYNINJAUIAPI TokenizedTextView: public QAbstractScrollArea, public Vie
4444
bool m_navByRef = false;
4545

4646
std::vector<BinaryNinja::LinearDisassemblyLine> m_lines;
47+
DisassemblySettingsRef m_settings;
4748

4849
QTimer* m_updateTimer;
4950

0 commit comments

Comments
 (0)