Improve Database Configuration Logging (#529)

Address #528

Author: kraftp

dbos/_app_db.py

@@ -70,6 +70,17 @@ def __init__(
         schema: Optional[str],
         debug_mode: bool = False,
     ):
+        # Log application database connection information
+        printable_url = sa.make_url(database_url).render_as_string(hide_password=True)
+        dbos_logger.info(
+            f"Initializing DBOS application database with URL: {printable_url}"
+        )
+        if not database_url.startswith("sqlite"):
+            dbos_logger.info(
+                f"DBOS application database engine parameters: {engine_kwargs}"
+            )
+
+        # Configure and initialize the application database
         if database_url.startswith("sqlite"):
             self.schema = None
         else:

dbos/_dbos_config.py

@@ -408,25 +408,6 @@ def process_config(
 
     configure_db_engine_parameters(data["database"], connect_timeout=connect_timeout)
 
-    assert data["system_database_url"] is not None
-    # Pretty-print connection information, respecting log level
-    if not silent and logs["logLevel"] == "INFO" or logs["logLevel"] == "DEBUG":
-        printable_sys_db_url = make_url(data["system_database_url"]).render_as_string(
-            hide_password=True
-        )
-        print(f"DBOS system database URL: {printable_sys_db_url}")
-        if data["database_url"]:
-            printable_app_db_url = make_url(data["database_url"]).render_as_string(
-                hide_password=True
-            )
-            print(f"DBOS application database URL: {printable_app_db_url}")
-        if data["system_database_url"].startswith("sqlite"):
-            print(
-                f"Using SQLite as a system database. The SQLite system database is for development and testing. PostgreSQL is recommended for production use."
-            )
-        else:
-            print(f"Database engine parameters: {data['database']['db_engine_kwargs']}")
-
     # Return data as ConfigFile type
     return data
 

dbos/_sys_db.py

@@ -405,6 +405,26 @@ def __init__(
         import sqlalchemy.dialects.postgresql as pg
         import sqlalchemy.dialects.sqlite as sq
 
+        # Log system database connection information
+        if engine:
+            dbos_logger.info("Initializing DBOS system database with custom engine")
+        else:
+            printable_sys_db_url = sa.make_url(system_database_url).render_as_string(
+                hide_password=True
+            )
+            dbos_logger.info(
+                f"Initializing DBOS system database with URL: {printable_sys_db_url}"
+            )
+            if system_database_url.startswith("sqlite"):
+                dbos_logger.info(
+                    f"Using SQLite as a system database. The SQLite system database is for development and testing. PostgreSQL is recommended for production use."
+                )
+            else:
+                dbos_logger.info(
+                    f"DBOS system database engine parameters: {engine_kwargs}"
+                )
+
+        # Configure and initialize the system database
         self.dialect = sq if system_database_url.startswith("sqlite") else pg
 
         self.serializer = serializer

dbos/cli/cli.py

@@ -1,4 +1,5 @@
 import json
+import logging
 import os
 import platform
 import signal
@@ -24,6 +25,7 @@
     load_config,
 )
 from .._docker_pg_helper import start_docker_pg, stop_docker_pg
+from .._logger import dbos_logger
 from .._sys_db import SystemDatabase
 from .._utils import GlobalParams
 from ..cli._github_init import create_template_from_github
@@ -48,6 +50,7 @@ def _get_db_url(
     Otherwise fallback to the same SQLite Postgres URL than the DBOS library.
     Note that for the latter to be possible, a configuration file must have been found, with an application name set.
     """
+    dbos_logger.setLevel(logging.WARNING)  # The CLI should not emit INFO logs
     if os.environ.get("DBOS__CLOUD") == "true":
         system_database_url = os.environ.get("DBOS_SYSTEM_DATABASE_URL")
         application_database_url = os.environ.get("DBOS_DATABASE_URL")