-
Notifications
You must be signed in to change notification settings - Fork 90
Open
Labels
enhancementIndicates new improvementsIndicates new improvementstriageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time
Description
The codebase currently lacks type hints. Adding type hints would greatly increase the ability for static type checkers like mypy
to enforce type-safety and catch bugs at type-checking time.
Adding mypy
or an equivalent type checker to pre-commit
would help maintain type-safety during the development process.
Operationally, I would suggest adding a type checker like mypy
to the pre-commit configuration, but exempting all modules from type checking (because they would all fail).
One by one, modules would be added to mypy's scope, and that module would receive complete type annotations. This should be a safe way to gradually type the entire codebase.
Metadata
Metadata
Assignees
Labels
enhancementIndicates new improvementsIndicates new improvementstriageIndicates issues, pull requests, or discussions need to be reviewed for the first timeIndicates issues, pull requests, or discussions need to be reviewed for the first time