Skip to content

Commit daeaf48

Browse files
authored
Cleanup some toString methods (#2532)
* Some minor toString cleanup/fixes * Address feedback
1 parent e428411 commit daeaf48

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

lib/src/model/package_graph.dart

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -704,15 +704,17 @@ class PackageGraph {
704704

705705
@override
706706
String toString() {
707-
final divider = '=========================================================';
708-
final buffer =
709-
StringBuffer('PackageGraph built from ${defaultPackage.name}');
707+
const divider = '=========================================================';
708+
final buffer = StringBuffer('PackageGraph built from ');
709+
buffer.writeln(defaultPackageName);
710710
buffer.writeln(divider);
711711
buffer.writeln();
712712
for (final name in packageMap.keys) {
713713
final package = packageMap[name];
714-
buffer.writeln('Package $name documented at ${package.documentedWhere} '
715-
'with libraries: ${package.allLibraries}');
714+
buffer.write('Package $name documented at ${package.documentedWhere} '
715+
'with libraries: ');
716+
buffer.writeAll(package.allLibraries);
717+
buffer.writeln();
716718
}
717719
buffer.writeln(divider);
718720
return buffer.toString();

lib/src/warnings.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -520,10 +520,10 @@ class PackageWarningCounter {
520520

521521
@override
522522
String toString() {
523-
var errors = '$errorCount ${errorCount == 1 ? "error" : "errors"}';
524-
var warnings =
523+
final errors = '$errorCount ${errorCount == 1 ? "error" : "errors"}';
524+
final warnings =
525525
'$warningCount ${warningCount == 1 ? "warning" : "warnings"}';
526-
return [errors, warnings].join(', ');
526+
return '$errors, $warnings';
527527
}
528528
}
529529

0 commit comments

Comments
 (0)