Skip to content

Commit 7bdd524

Browse files
authored
Merge pull request #1183 from dart-lang/remove_librato
remove the use of the librato package
2 parents efc8723 + d1dc60d commit 7bdd524

File tree

3 files changed

+12
-48
lines changed

3 files changed

+12
-48
lines changed

pubspec.lock

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ packages:
5454
name: collection
5555
url: "https://pub.dartlang.org"
5656
source: hosted
57-
version: "1.5.1"
57+
version: "1.8.0"
5858
contrast:
5959
description:
6060
name: contrast
@@ -127,12 +127,6 @@ packages:
127127
url: "https://pub.dartlang.org"
128128
source: hosted
129129
version: "2.2.1"
130-
librato:
131-
description:
132-
name: librato
133-
url: "https://pub.dartlang.org"
134-
source: hosted
135-
version: "0.0.3"
136130
logging:
137131
description:
138132
name: logging
@@ -288,7 +282,7 @@ packages:
288282
name: test
289283
url: "https://pub.dartlang.org"
290284
source: hosted
291-
version: "0.12.13+1"
285+
version: "0.12.14"
292286
typed_data:
293287
description:
294288
name: typed_data
@@ -343,4 +337,4 @@ packages:
343337
url: "https://pub.dartlang.org"
344338
source: hosted
345339
version: "2.1.8"
346-
sdk: ">=1.14.0 <1.18.0"
340+
sdk: ">=1.14.0 <1.19.0"

pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ dev_dependencies:
2424
den_api: ^0.1.0
2525
grinder: ^0.8.0
2626
http: ^0.11.0
27-
librato: ^0.0.3
2827
pub_semver: ^1.0.0
2928
test: ^0.12.0
3029
which: ^0.1.3

tool/grind.dart

Lines changed: 9 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import 'package:den_api/den_api.dart';
1111
import 'package:grinder/grinder.dart';
1212
import 'package:html/dom.dart';
1313
import 'package:html/parser.dart' show parse;
14-
import 'package:librato/librato.dart';
1514
import 'package:path/path.dart' as path;
1615
import 'package:yaml/yaml.dart' as yaml;
1716

@@ -137,18 +136,15 @@ analyze() {
137136
Future buildSdkDocs() async {
138137
delete(docsDir);
139138
log('building SDK docs');
140-
int sdkDocsGenTime = await _runAsyncTimed(() async {
141-
var process = await Process.start(Platform.resolvedExecutable, [
142-
'bin/dartdoc.dart',
143-
'--output',
144-
'${docsDir.path}',
145-
'--sdk-docs',
146-
'--show-progress'
147-
]);
148-
stdout.addStream(process.stdout);
149-
stderr.addStream(process.stderr);
150-
});
151-
return _uploadStats(sdkDocsGenTime);
139+
var process = await Process.start(Platform.resolvedExecutable, [
140+
'bin/dartdoc.dart',
141+
'--output',
142+
'${docsDir.path}',
143+
'--sdk-docs',
144+
'--show-progress'
145+
]);
146+
stdout.addStream(process.stdout);
147+
stderr.addStream(process.stderr);
152148
}
153149

154150
@Task('Validate the SDK doc build.')
@@ -207,31 +203,6 @@ indexResources() {
207203
@Depends(analyze, test, testDartdoc)
208204
buildbot() => null;
209205

210-
Future<int> _runAsyncTimed(Future callback()) async {
211-
var stopwatch = new Stopwatch()..start();
212-
await callback();
213-
stopwatch.stop();
214-
return stopwatch.elapsedMilliseconds;
215-
}
216-
217-
Future _uploadStats(int sdkDocsGenTime) async {
218-
Map env = Platform.environment;
219-
220-
if (env.containsKey('LIBRATO_USER') && env.containsKey('TRAVIS_COMMIT')) {
221-
Librato librato = new Librato.fromEnvVars();
222-
log('Uploading stats to ${librato.baseUrl}');
223-
LibratoStat sdkDocsGenTimeStat =
224-
new LibratoStat('sdk-docs-gen-time', sdkDocsGenTime);
225-
await librato.postStats([sdkDocsGenTimeStat]);
226-
String commit = env['TRAVIS_COMMIT'];
227-
LibratoLink link = new LibratoLink(
228-
'github', 'https://github.com/dart-lang/dart-pad/commit/${commit}');
229-
LibratoAnnotation annotation = new LibratoAnnotation(commit,
230-
description: 'Commit ${commit}', links: [link]);
231-
return librato.createAnnotation('build_ui', annotation);
232-
}
233-
}
234-
235206
// TODO: check http links, check links in <link>
236207
// Also TODO: put a guard for infinite link checking
237208
@Task('Check links')

0 commit comments

Comments
 (0)