Skip to content

Commit 64ded5f

Browse files
authored
Remove compare_output_test (#1881)
* Cleanup and move test-only code into the test utils library * Fix coverage for binary-level tests * dartfmt * Adjust timeout factor * Unconditionally add coverage path environment variable * Move main up to the top; coverage runs take a bit more time * Remove compare_output_test * git attributes for output test removal
1 parent a86cd9b commit 64ded5f

File tree

1,982 files changed

+2
-338725
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,982 files changed

+2
-338725
lines changed

.gitattributes

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,3 @@
33
# Don't collapse in github code reviews by default.
44
lib/src/version.dart linguist-generated=false
55
lib/src/html/resources.g.dart linguist-generated=false
6-
7-
# Do collapse in github code reviews by default.
8-
testing/test_package_docs/** linguist-generated=true
9-
testing/test_package_docs_dev/** linguist-generated=true

CONTRIBUTING.md

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,10 @@ yet in the issue tracker, start by opening an issue. Thanks!
2323

2424
1. `grind` is needed to run dartdoc integration tests, see installed via `pub global activate grinder`.
2525
2. When a change is user-facing, please add a new entry to the [changelog](https://github.com/dart-lang/dartdoc/blob/master/CHANGELOG.md)
26-
3. Please include a test for your change. `dartdoc` has both `package:test`-style unittests as well as integration tests. To run the unittests, use `dart test/all.dart`. Most changes can be tested via a unittest, but some require modifying the [test_package](https://github.com/dart-lang/dartdoc/tree/master/testing/test_package) and regenerating its docs via `grind update-test-package-docs`.
26+
3. Please include a test for your change. `dartdoc` has both `package:test`-style unittests as well as integration tests. To run the unittests, use `grind test`.
2727
4. For major changes, run `grind compare-sdk-warnings` and `grind compare-flutter-warnings`, and include the summary results in your pull request.
2828
5. Be sure to format your Dart code using `dartfmt -w`, otherwise travis will complain.
29-
6. Because there are generated versions of the dartdoc docs for stable and development versions of Dart,
30-
you need to update the docs twice:
31-
- Download and install the latest STABLE version of dart from [the Dart website](https://www.dartlang.org/tools/sdk).
32-
(It's probably easiest to download a zip file and change your PATH to the extracted location's `bin` directory)
33-
- Run `pub run grinder update-test-package-docs` to update the stable docs (in `testing/test_package_docs`).
34-
- Download and install the latest DEV version of dart from [the Dart website](https://www.dartlang.org/tools/sdk)
35-
(It's probably easiest to download a zip file and change your PATH to the extracted location's `bin` directory)
36-
- Run `pub run grinder update-test-package-docs` to update the dev docs (in `testing/test_package_docs_dev`).
37-
7. Post your change via a pull request for review and integration!
29+
6. Post your change via a pull request for review and integration!
3830

3931
## Testing
4032

test/compare_output_test.dart

Lines changed: 0 additions & 281 deletions
This file was deleted.

0 commit comments

Comments
 (0)