Description
I'm using sqljocky5 with SSL connections to the database, and have some suggestions/feature requests:
-
Reduce the logging level. In lib/src/auth/handshake_handler.dart line 135, it performs some logging with
log.shout("SSL enabled");which tends to fill the logs with unnecessary entries. It would be better if that was a fine, finer, or finest level log entry. -
Provide hooks for a client program to perform additional security checks. For example,
a. Validating the server/database certificate (as well as the trust chain of CA certificates).
b. Checking the domain name inside the certificate matches the expected database host.
b. Performing other checks, such as if the certificate has expired. -
The ability to specify (or obtain) the version of SSL/TLS and ciphers used.
Activity
tejainece commentedon Feb 15, 2019
@hoylen Can you submit a PR for 2 and 3?
hoylen commentedon Feb 15, 2019
Unfortunately, sqljocky5 v2.2.0 no longer supports TLS/SSL. This is disappointing.
Line 168 of comm/comm.dart triggers an assertion if useSSL is true.
tejainece commentedon Feb 15, 2019
I will implement it.
Did original sqljocky package support
useSSLproperly?hoylen commentedon Feb 15, 2019
Yes, sqljocky5 v1.0.0 used to work with
useSSLset to true.tejainece commentedon Feb 15, 2019
Ok. I will fix this. PRs are also welcome.
hoylen commentedon Feb 15, 2019
Sorry, I can't help with this. I don't understand the sqljocky5 code base well enough, and can't figure out the API documentation.
tejainece commentedon Feb 15, 2019
Ok. No problem. Help with pointers to mysql protocols and code review will also be very helpful.
tejainece commentedon Feb 15, 2019
I will also add more documentation to APIs and architecture.