update sdk to support java 8 (microsoft#44)

* update sdk to support java 8

* change jdk8 vendor

* change to linux excution file

* resolve hard code issue in sdk build.gradle

Author: kaibocai

.github/workflows/build-validation.yml

@@ -27,6 +27,15 @@ jobs:
       with:
         java-version: '11'
         distribution: 'microsoft'
+    - name: set JDK_11 environment variable test compiling and running
+      env:
+        ACTIONS_ALLOW_UNSECURE_COMMANDS: true
+      run: echo ::set-env name=JDK_11::$(echo $JAVA_HOME)
+    - name: Set up JDK 8
+      uses: actions/setup-java@v2
+      with:
+        java-version: '8'
+        distribution: 'temurin'
     - name: Build with Gradle
       uses: gradle/gradle-build-action@bc3340afc5e3cc44f2321809ac090d731c13c514
       with:

azurefunctions/build.gradle

@@ -21,6 +21,9 @@ dependencies {
     implementation "com.google.protobuf:protobuf-java:${protocVersion}"
 }
 
+sourceCompatibility = 8
+targetCompatibility = 8
+
 publishing {
     publications {
         mavenPublication(MavenPublication) {

samples/src/main/java/io/durabletask/samples/FanOutFanInPattern.java

@@ -6,6 +6,7 @@
 
 import java.io.IOException;
 import java.time.Duration;
+import java.util.Arrays;
 import java.util.List;
 import java.util.StringTokenizer;
 import java.util.stream.Collectors;
@@ -23,7 +24,7 @@ public static void main(String[] args) throws IOException, InterruptedException
         final DurableTaskClient client = DurableTaskGrpcClient.newBuilder().build();
 
         // The input is an arbitrary list of strings.
-        List<String> listOfStrings = List.of(
+        List<String> listOfStrings =  Arrays.asList(
                 "Hello, world!",
                 "The quick brown fox jumps over the lazy dog.",
                 "If a tree falls in the forest and there is no one there to hear it, does it make a sound?",

sdk/build.gradle

@@ -13,6 +13,7 @@ archivesBaseName = 'durabletask-sdk'
 def grpcVersion = '1.38.0'
 def protocVersion = '3.12.0'
 def jacksonVersion = '2.12.3'
+def PATH_TO_TEST_JAVA_RUNTIME = "$System.env.JDK_11"
 
 dependencies {
 
@@ -33,6 +34,16 @@ dependencies {
     testImplementation('org.junit.jupiter:junit-jupiter')
 }
 
+compileJava {
+    sourceCompatibility = 1.8
+}
+compileTestJava {
+    sourceCompatibility = 11
+    targetCompatibility = 11
+    options.fork = true
+    options.forkOptions.executable = "${PATH_TO_TEST_JAVA_RUNTIME}/bin/javac"
+}
+
 protobuf {
     protoc { artifact = "com.google.protobuf:protoc:${protocVersion}" }
     plugins {
@@ -55,6 +66,10 @@ sourceSets {
     }
 }
 
+tasks.withType(Test) {
+    executable = new File("${PATH_TO_TEST_JAVA_RUNTIME}", 'bin/java')
+}
+
 test {
     useJUnitPlatform {
         // Skip tests tagged as "integration" since those are slower

sdk/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClient.java

@@ -27,7 +27,7 @@ public class DurableTaskGrpcClient extends DurableTaskClient {
     private final TaskHubSidecarServiceBlockingStub sidecarClient;
 
     private DurableTaskGrpcClient(Builder builder) {
-        this.dataConverter = Objects.requireNonNullElseGet(builder.dataConverter, JacksonDataConverter::new);
+        this.dataConverter = builder.dataConverter != null ? builder.dataConverter : new JacksonDataConverter();
 
         Channel sidecarGrpcChannel;
         if (builder.channel != null) {

sdk/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorker.java

@@ -54,7 +54,7 @@ private DurableTaskGrpcWorker(Builder builder) {
         }
 
         this.sidecarClient = TaskHubSidecarServiceGrpc.newBlockingStub(sidecarGrpcChannel);
-        this.dataConverter = Objects.requireNonNullElse(builder.dataConverter, new JacksonDataConverter());
+        this.dataConverter = builder.dataConverter != null ? builder.dataConverter : new JacksonDataConverter();
     }
 
     public void start() {
@@ -86,11 +86,11 @@ private String getSidecarAddress() {
     public void runAndBlock() throws InterruptedException {
         logger.log(Level.INFO, "Durable Task worker is connecting to sidecar at {0}.", this.getSidecarAddress());
 
-        var taskOrchestrationExecutor = new TaskOrchestrationExecutor(
+        TaskOrchestrationExecutor taskOrchestrationExecutor = new TaskOrchestrationExecutor(
                 this.orchestrationFactories,
                 this.dataConverter,
                 logger);
-        var taskActivityExecutor = new TaskActivityExecutor(
+        TaskActivityExecutor taskActivityExecutor = new TaskActivityExecutor(
                 this.activityFactories,
                 this.dataConverter,
                 logger);

sdk/src/main/java/com/microsoft/durabletask/FailureDetails.java

@@ -24,7 +24,7 @@ class FailureDetails {
         this.stackTrace = errorDetails;
 
         // Error message can be null for things like NullPointerException but the gRPC contract doesn't allow null
-        this.errorMessage = Objects.requireNonNullElse(errorMessage, "");
+        this.errorMessage = errorMessage != null ? errorMessage : "";
         this.isNonRetriable = isNonRetriable;
     }
 
@@ -86,7 +86,7 @@ TaskFailureDetails toProto() {
         return TaskFailureDetails.newBuilder()
                 .setErrorType(this.getErrorType())
                 .setErrorMessage(this.getErrorMessage())
-                .setStackTrace(StringValue.of(Objects.requireNonNullElse(this.getStackTrace(), "")))
+                .setStackTrace(StringValue.of(this.getStackTrace() != null ? this.getStackTrace() : ""))
                 .build();
     }
 }

sdk/src/main/java/com/microsoft/durabletask/OrchestrationRunner.java

@@ -64,7 +64,7 @@ public static byte[] loadAndRun(byte[] triggerStateProtoBytes, TaskOrchestration
         }
 
         // Register the passed orchestration as the default ("*") orchestration
-        var orchestrationFactories = new HashMap<String, TaskOrchestrationFactory>();
+        HashMap orchestrationFactories = new HashMap<String, TaskOrchestrationFactory>();
         orchestrationFactories.put("*", new TaskOrchestrationFactory() {
             @Override
             public String getName() {
@@ -77,7 +77,7 @@ public TaskOrchestration create() {
             }
         });
 
-        var taskOrchestrationExecutor = new TaskOrchestrationExecutor(
+        TaskOrchestrationExecutor taskOrchestrationExecutor = new TaskOrchestrationExecutor(
                 orchestrationFactories,
                 new JacksonDataConverter(),
                 logger);

sdk/src/main/java/com/microsoft/durabletask/RetryPolicy.java

@@ -18,8 +18,8 @@ private RetryPolicy(Builder builder) {
         this.maxNumberOfAttempts = builder.maxNumberOfAttempts;
         this.firstRetryInterval = builder.firstRetryInterval;
         this.backoffCoefficient = builder.backoffCoefficient;
-        this.maxRetryInterval = Objects.requireNonNullElse(builder.maxRetryInterval, Duration.ZERO);
-        this.retryTimeout = Objects.requireNonNullElse(builder.retryTimeout, Duration.ZERO);
+        this.maxRetryInterval = builder.maxRetryInterval != null ? builder.maxRetryInterval : Duration.ZERO;
+        this.retryTimeout = builder.retryTimeout != null ? builder.retryTimeout : Duration.ZERO;
     }
 
     public static Builder newBuilder(int maxNumberOfAttempts, Duration firstRetryInterval) {