chore: remove dead code from errors.ts in packages/errors (#31536)

* chore: remove 'not logged in' error - which is dead code

* Remove function getMsgByType which is no longer called in code

* remove errors around 'private test' plans

* Remove snapshots

* update system test snapshot

Author: jennifer-shehane

packages/errors/__snapshot-html__/NOT_LOGGED_IN.html renamed to packages/errors/__snapshot-html__/CDP_FIREFOX_DEPRECATED.html

@@ -138,12 +138,6 @@ export const AllCypressErrors = {
 
         ${fmt.highlightSecondary(arg2)}`
   },
-  NOT_LOGGED_IN: () => {
-    return errTemplate`\
-        You're not logged in.
-
-        Run ${fmt.highlight(`cypress open`)} to open Cypress and log in.`
-  },
   TESTS_DID_NOT_START_RETRYING: (arg1: string) => {
     return errTemplate`Timed out waiting for the browser to connect. ${fmt.off(arg1)}`
   },
@@ -1032,30 +1026,6 @@ export const AllCypressErrors = {
 
         https://on.cypress.io/installing-cypress`
   },
-  FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS: (arg1: {link: string, usedTestsMessage: string, limit: number}) => {
-    return errTemplate`\
-        You've exceeded the limit of private test results under your free plan this month. ${getUsedTestsMessage(arg1.limit, arg1.usedTestsMessage)}
-
-        To continue recording tests this month you must upgrade your account. Please visit your billing to upgrade to another billing plan.
-
-        ${fmt.off(arg1.link)}`
-  },
-  FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS: (arg1: {link: string, usedTestsMessage: string, gracePeriodMessage: string, limit: number}) => {
-    return errTemplate`\
-        You've exceeded the limit of private test results under your free plan this month. ${getUsedTestsMessage(arg1.limit, arg1.usedTestsMessage)}
-
-        Your plan is now in a grace period, which means your tests will still be recorded until ${fmt.off(arg1.gracePeriodMessage)}. Please upgrade your plan to continue recording tests on Cypress Cloud in the future.
-
-        ${fmt.off(arg1.link)}`
-  },
-  PAID_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS: (arg1: {link: string, usedTestsMessage: string, limit: number}) => {
-    return errTemplate`\
-        You've exceeded the limit of private test results under your current billing plan this month. ${getUsedTestsMessage(arg1.limit, arg1.usedTestsMessage)}
-
-        To upgrade your account, please visit your billing to upgrade to another billing plan.
-
-        ${fmt.off(arg1.link)}`
-  },
   FREE_PLAN_EXCEEDS_MONTHLY_TESTS: (arg1: {link: string, usedTestsMessage: string, limit: number}) => {
     return errTemplate`\
         You've exceeded the limit of test results under your free plan this month. ${getUsedTestsMessage(arg1.limit, arg1.usedTestsMessage)}
@@ -1901,12 +1871,6 @@ export type AllCypressErrorObj = typeof AllCypressErrors
 
 export type AllCypressErrorNames = keyof typeof AllCypressErrors
 
-export function getMsgByType<Type extends keyof AllCypressErrorObj> (type: Type, ...args: Parameters<AllCypressErrorObj[Type]>): string {
-  const err = getError(type, ...args)
-
-  return err.message
-}
-
 /**
  * Given an error name & params for the error, returns a "CypressError",
  * with a forBrowser property, used when we want to format the value for sending to

packages/errors/__snapshot-html__/FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS.html

@@ -17,7 +17,7 @@ describe('lib/errors', () => {
 
   context('.log', () => {
     it('uses red by default', () => {
-      const err = errors.get('NOT_LOGGED_IN')
+      const err = errors.get('TESTS_DID_NOT_START_FAILED')
 
       const ret = errors.log(err)
 
@@ -33,7 +33,7 @@ describe('lib/errors', () => {
     })
 
     it('can change the color', () => {
-      const err = errors.get('NOT_LOGGED_IN')
+      const err = errors.get('TESTS_DID_NOT_START_FAILED')
 
       const ret = errors.log(err, 'yellow')
 

packages/errors/__snapshot-html__/FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS.html

@@ -364,11 +364,6 @@ describe('visual error templates', () => {
         default: ['/path/does/not/exist', err.message],
       }
     },
-    NOT_LOGGED_IN: () => {
-      return {
-        default: [],
-      }
-    },
     TESTS_DID_NOT_START_RETRYING: () => {
       return {
         default: ['Retrying...'],
@@ -971,34 +966,6 @@ describe('visual error templates', () => {
         default: [],
       }
     },
-    FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS: () => {
-      return {
-        default: [{
-          link: 'https://cloud.cypress.io/project/abcd',
-          limit: 500,
-          usedTestsMessage: 'test',
-        }],
-      }
-    },
-    FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS: () => {
-      return {
-        default: [{
-          link: 'https://cloud.cypress.io/project/abcd',
-          limit: 500,
-          usedTestsMessage: 'test',
-          gracePeriodMessage: 'the grace period ends',
-        }],
-      }
-    },
-    PAID_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS: () => {
-      return {
-        default: [{
-          link: 'https://on.cypress.io/set-up-billing',
-          limit: 25000,
-          usedTestsMessage: 'private test',
-        }],
-      }
-    },
     FREE_PLAN_EXCEEDS_MONTHLY_TESTS: () => {
       return {
         default: [{

packages/errors/__snapshot-html__/PAID_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS.html

@@ -1207,9 +1207,7 @@ enum ErrorTypeEnum {
   FIREFOX_GECKODRIVER_FAILURE
   FIXTURE_NOT_FOUND
   FOLDER_NOT_WRITABLE
-  FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS
   FREE_PLAN_EXCEEDS_MONTHLY_TESTS
-  FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS
   FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_TESTS
   FREE_PLAN_IN_GRACE_PERIOD_PARALLEL_FEATURE
   INCOMPATIBLE_PLUGIN_RETRIES
@@ -1229,12 +1227,10 @@ enum ErrorTypeEnum {
   MIGRATION_CYPRESS_NOT_FOUND
   MIGRATION_MISMATCHED_CYPRESS_VERSIONS
   MULTIPLE_SUPPORT_FILES_FOUND
-  NOT_LOGGED_IN
   NO_DEFAULT_CONFIG_FILE_FOUND
   NO_PROJECT_FOUND_AT_PROJECT_ROOT
   NO_PROJECT_ID
   NO_SPECS_FOUND
-  PAID_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS
   PARALLEL_FEATURE_NOT_AVAILABLE_IN_PLAN
   PLAN_EXCEEDS_MONTHLY_TESTS
   PLAN_IN_GRACE_PERIOD_RUN_GROUPING_FEATURE_USED

packages/errors/src/errors.ts

@@ -306,13 +306,6 @@ const createRun = Promise.method((options: any = {}) => {
 
     return _.each(response.warnings, (warning: any) => {
       switch (warning.code) {
-        case 'FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS':
-          return errorsWarning('FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_PRIVATE_TESTS', {
-            limit: warning.limit,
-            usedTestsMessage: 'private test',
-            gracePeriodMessage: gracePeriodMessage(warning.gracePeriodEnds),
-            link: billingLink(warning.orgId),
-          })
         case 'FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_TESTS':
           return errorsWarning('FREE_PLAN_IN_GRACE_PERIOD_EXCEEDS_MONTHLY_TESTS', {
             limit: warning.limit,
@@ -332,13 +325,6 @@ const createRun = Promise.method((options: any = {}) => {
             usedTestsMessage: 'test',
             link: billingLink(warning.orgId),
           })
-        case 'PAID_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS':
-          return errorsWarning('PLAN_EXCEEDS_MONTHLY_TESTS', {
-            planType: 'current',
-            limit: warning.limit,
-            usedTestsMessage: 'private test',
-            link: billingLink(warning.orgId),
-          })
         case 'PAID_PLAN_EXCEEDS_MONTHLY_TESTS':
           return errorsWarning('PLAN_EXCEEDS_MONTHLY_TESTS', {
             planType: 'current',
@@ -380,12 +366,6 @@ const createRun = Promise.method((options: any = {}) => {
         const orgId = _.get(payload, 'orgId')
 
         switch (code) {
-          case 'FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS':
-            return throwErr('FREE_PLAN_EXCEEDS_MONTHLY_PRIVATE_TESTS', {
-              limit,
-              usedTestsMessage: 'private test',
-              link: billingLink(orgId),
-            })
           case 'FREE_PLAN_EXCEEDS_MONTHLY_TESTS':
             return throwErr('FREE_PLAN_EXCEEDS_MONTHLY_TESTS', {
               limit,

packages/errors/test/unit/errors_spec.ts

@@ -28,7 +28,7 @@ context('.logException', () => {
     sinon.stub(exception, 'create').resolves()
     sinon.stub(process.env, 'CYPRESS_INTERNAL_ENV').value('production')
 
-    const err = errors.get('NOT_LOGGED_IN')
+    const err = errors.get('TESTS_DID_NOT_START_FAILED')
 
     return errors.logException(err)
     .then(() => {
@@ -56,7 +56,7 @@ context('.logException', () => {
     sinon.stub(exception, 'create').rejects(new Error('foo'))
     sinon.stub(process.env, 'CYPRESS_INTERNAL_ENV').value('production')
 
-    const err = errors.get('NOT_LOGGED_IN')
+    const err = errors.get('TESTS_DID_NOT_START_FAILED')
 
     return errors.logException(err)
     .then((ret) => {

packages/errors/test/unit/visualSnapshotErrors_spec.ts

@@ -1878,9 +1878,9 @@ Warning from Cypress Cloud:
 This feature will not be supported soon, please check with Cypress to learn more: https://on.cypress.io/
 ----------------------------------------------------------------------
 
-You've exceeded the limit of private test results under your free plan this month. The limit is 500 private test results.
+You've exceeded the limit of test results under your current billing plan this month. The limit is 500 test results.
 
-Your plan is now in a grace period, which means your tests will still be recorded until 2999-12-31. Please upgrade your plan to continue recording tests on Cypress Cloud in the future.
+To continue getting the full benefits of your current plan, please visit your billing to upgrade.
 
 https://on.cypress.io/dashboard/organizations/org-id-1234/billing