Issue: The find_run_neighbours() method uses ICRS coordinate system when selecting the run neighbors, which may lead to runs with very different zenith distances to be stacked when evaluating the background.
Suggestion: use Alt/Az instead of ICRS in find_run_neighbours():
- introduce
az_bins and alt_bins keywords to the configuration file with the following behavior: if integers, they will define the Az/sin(Alt) grid to be used when searching for neighbors; if lists, they will define the Alt and Az grid bin edges;
- add the alt/az neighboring grid creation in
BkgMakerBase.from_config_file();
- change the
pointing_delta argument of find_run_neighbours() to neighboring _grid or similar and provide the grid from step 2 here.
Issue: The
find_run_neighbours()method uses ICRS coordinate system when selecting the run neighbors, which may lead to runs with very different zenith distances to be stacked when evaluating the background.Suggestion: use Alt/Az instead of ICRS in
find_run_neighbours():az_binsandalt_binskeywords to the configuration file with the following behavior: if integers, they will define the Az/sin(Alt) grid to be used when searching for neighbors; if lists, they will define the Alt and Az grid bin edges;BkgMakerBase.from_config_file();pointing_deltaargument offind_run_neighbours()toneighboring _gridor similar and provide the grid from step 2 here.