Skip to content

Commit fb5a218

Browse files
authored
fix: revert "test: add e2e tests for navigation (MetaMask#25652)" (MetaMask#25725)
This reverts commit 6c2cadd. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR broke firefox-confirmation-redesign test for Navigation, so we are reverting it until a fix is found. https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/90592/workflows/d0a8a134-7f1e-4b79-b075-8cf4a343ccc9/jobs/3361587/tests [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25725?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent a23e2a4 commit fb5a218

File tree

3 files changed

+0
-222
lines changed

3 files changed

+0
-222
lines changed

test/e2e/tests/confirmations/navigation.spec.ts

Lines changed: 0 additions & 216 deletions
This file was deleted.

ui/pages/confirmations/components/confirm/nav/__snapshots__/nav.test.tsx.snap

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ exports[`ConfirmNav should match snapshot 1`] = `
1212
<button
1313
aria-label="Previous Confirmation"
1414
class="mm-box mm-button-icon mm-button-icon--size-sm confirm_nav__left_btn mm-box--display-inline-flex mm-box--justify-content-center mm-box--align-items-center mm-box--color-icon-alternative mm-box--background-color-background-alternative mm-box--rounded-full"
15-
data-testid="confirm-nav__previous-confirmation"
1615
>
1716
<span
1817
class="mm-box mm-icon mm-icon--size-sm mm-box--display-inline-block mm-box--color-inherit"
@@ -29,7 +28,6 @@ exports[`ConfirmNav should match snapshot 1`] = `
2928
<button
3029
aria-label="Next Confirmation"
3130
class="mm-box mm-button-icon mm-button-icon--size-sm confirm_nav__right_btn mm-box--display-inline-flex mm-box--justify-content-center mm-box--align-items-center mm-box--color-icon-alternative mm-box--background-color-background-alternative mm-box--rounded-full"
32-
data-testid="confirm-nav__next-confirmation"
3331
>
3432
<span
3533
class="mm-box mm-icon mm-icon--size-sm mm-box--display-inline-block mm-box--color-inherit"
@@ -39,7 +37,6 @@ exports[`ConfirmNav should match snapshot 1`] = `
3937
</div>
4038
<button
4139
class="mm-box mm-text mm-button-base mm-button-base--size-md confirm_nav__reject_all mm-button-primary mm-text--body-md-medium mm-text--font-weight-normal mm-box--padding-0 mm-box--padding-right-3 mm-box--padding-left-3 mm-box--display-inline-flex mm-box--justify-content-center mm-box--align-items-center mm-box--color-primary-inverse mm-box--background-color-primary-default mm-box--rounded-xl"
42-
data-testid="confirm-nav__reject-all"
4340
type="secondary"
4441
>
4542
<span

ui/pages/confirmations/components/confirm/nav/nav.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ const Nav = () => {
101101
<Box alignItems={AlignItems.center} display={Display.Flex}>
102102
<ButtonIcon
103103
ariaLabel="Previous Confirmation"
104-
data-testid="confirm-nav__previous-confirmation"
105104
backgroundColor={BackgroundColor.backgroundAlternative}
106105
borderRadius={BorderRadius.full}
107106
className="confirm_nav__left_btn"
@@ -120,7 +119,6 @@ const Nav = () => {
120119
</Text>
121120
<ButtonIcon
122121
ariaLabel="Next Confirmation"
123-
data-testid="confirm-nav__next-confirmation"
124122
backgroundColor={BackgroundColor.backgroundAlternative}
125123
borderRadius={BorderRadius.full}
126124
className="confirm_nav__right_btn"
@@ -136,7 +134,6 @@ const Nav = () => {
136134
<Button
137135
borderRadius={BorderRadius.XL}
138136
className="confirm_nav__reject_all"
139-
data-testid="confirm-nav__reject-all"
140137
fontWeight={FontWeight.Normal}
141138
onClick={onRejectAll}
142139
paddingLeft={3}

0 commit comments

Comments
 (0)