improve CoverageResultTaskTests

Author: Bertk

test/coverlet.msbuild.tasks.tests/CoverageResultTaskTests.cs

@@ -70,7 +70,7 @@ public void Execute_StateUnderTest_MissingInstrumentationState()
     }
 
     [Fact]
-    public void Execute_StateUnderTest_WithInstrumentationState_Fake()
+    public void Execute_StateUnderTest_WithInstrumentationState_ThresholdType()
     {
       // Arrange
       var mockFileSystem = new Mock<IFileSystem>();
@@ -89,18 +89,15 @@ public void Execute_StateUnderTest_WithInstrumentationState_Fake()
       BaseTask.ServiceProvider = serviceProvider;
       _buildEngine.Setup(x => x.LogErrorEvent(It.IsAny<BuildErrorEventArgs>())).Callback<BuildErrorEventArgs>(e => _errors.Add(e));
 
-#pragma warning disable CS8604 // Possible null reference argument for parameter..
-#pragma warning disable CS8602 // Dereference of a possibly null reference.
-      var InstrumenterState = new TaskItem(Path.Combine(AppDomain.CurrentDomain.SetupInformation.ApplicationBase, "TestAssets\\InstrumenterState.ItemSpec.data1.xml"));
-#pragma warning restore CS8602 // Dereference of a possibly null reference.
-#pragma warning restore C8S604 // Possible null reference argument for parameter.
+      var baseDirectory = AppDomain.CurrentDomain.SetupInformation.ApplicationBase ?? string.Empty;
+      var InstrumenterState = new TaskItem(Path.Combine(baseDirectory, "TestAssets\\InstrumenterState.ItemSpec.data1.xml"));
 
       var coverageResultTask = new CoverageResultTask
       {
         OutputFormat = "cobertura",
         Output = "coverageDir",
         Threshold = "50",
-        ThresholdType = "total",
+        ThresholdType = "line,branch,method",
         ThresholdStat = "total",
         InstrumenterState = InstrumenterState
       };
@@ -110,12 +107,18 @@ public void Execute_StateUnderTest_WithInstrumentationState_Fake()
       bool success = coverageResultTask.Execute();
 
       // Assert
-      Assert.True(success);
-      Assert.False(coverageResultTask.Log.HasLoggedErrors);
+      Assert.False(success);
+      Assert.True(coverageResultTask.Log.HasLoggedErrors);
+
+      // Verify the error message
+      string expectedErrorMessage = "The total line coverage is below the specified 50\r\n" +
+                           "The total branch coverage is below the specified 50\r\n" +
+                           "The total method coverage is below the specified 50";
+
+      Assert.Contains(expectedErrorMessage, _errors[0].Message);
 
       Assert.Contains("coverageDir.cobertura.xml", coverageResultTask.ReportItems[0].ItemSpec);
       Assert.Equal(16, coverageResultTask.ReportItems[0].MetadataCount);
-
     }
 
   }