improve excludeAssembliesWithoutSources parameter validation

Author: Bertk

global.json

@@ -1,5 +1,5 @@
 {
     "sdk": {
-        "version": "8.0.408"
+        "version": "8.0.409"
     }
 }

src/coverlet.console/Program.cs

@@ -48,7 +48,7 @@ static int Main(string[] args)
       var mergeWith = new Option<string>("--merge-with", "Path to existing coverage result to merge.") { Arity = ArgumentArity.ZeroOrOne };
       var useSourceLink = new Option<bool>("--use-source-link", "Specifies whether to use SourceLink URIs in place of file system paths.") { Arity = ArgumentArity.Zero };
       var doesNotReturnAttributes = new Option<string[]>("--does-not-return-attribute", "Attributes that mark methods that do not return") { Arity = ArgumentArity.ZeroOrMore, AllowMultipleArgumentsPerToken = true };
-      var excludeAssembliesWithoutSources = new Option<string>("--exclude-assemblies-without-sources", "Specifies behavior of heuristic to ignore assemblies with missing source documents.") { Arity = ArgumentArity.ZeroOrOne };
+      Option<string> excludeAssembliesWithoutSources = new Option<string>("--exclude-assemblies-without-sources", "Specifies behavior of heuristic to ignore assemblies with missing source documents.").FromAmong("MissingAll", "MissingAny", "None");
       var sourceMappingFile = new Option<string>("--source-mapping-file", "Specifies the path to a SourceRootsMappings file.") { Arity = ArgumentArity.ZeroOrOne };
 
       RootCommand rootCommand = new()

test/coverlet.integration.tests/DotnetTool.cs

@@ -141,5 +141,89 @@ public void StandAloneThresholdLineAndMethod()
       Assert.Contains("The minimum line coverage is below the specified 80", standardOutput);
       Assert.Contains("The minimum method coverage is below the specified 80", standardOutput);
     }
+
+    [Fact]
+    public void ExcludeAssembliesWithoutSources_WrongValue()
+    {
+      using ClonedTemplateProject clonedTemplateProject = CloneTemplateProject();
+      UpdateNugetConfigWithLocalPackageFolder(clonedTemplateProject.ProjectRootPath!);
+      string coverletToolCommandPath = InstallTool(clonedTemplateProject.ProjectRootPath!);
+      string outputPath = $"{clonedTemplateProject.ProjectRootPath}{Path.DirectorySeparatorChar}coverage.json";
+
+      // Build the test project
+      DotnetCli($"build -f {_buildTargetFramework} {clonedTemplateProject.ProjectRootPath}",
+          out string buildOutput,
+          out string buildError);
+
+      string publishedTestFile = clonedTemplateProject.GetFiles("*" + ClonedTemplateProject.AssemblyName + ".dll")
+          .Single(f => !f.Contains("obj") && !f.Contains("ref"));
+
+      // Run coverage with exclude-assemblies-without-sources parameter
+      int cmdExitCode = RunCommand(
+          coverletToolCommandPath,
+          $"\"{publishedTestFile}\" --target \"dotnet\" " +
+          $"--targetargs \"test {Path.Combine(clonedTemplateProject.ProjectRootPath, ClonedTemplateProject.ProjectFileName)} --no-build\" " +
+          $"--exclude-assemblies-without-sources nonsense " +
+          $"--output \"{outputPath}\"",
+          out string standardOutput,
+          out string standardError);
+
+      if (!string.IsNullOrEmpty(standardError))
+      {
+        _output.WriteLine(standardError);
+      }
+      else
+      {
+        _output.WriteLine(standardOutput);
+      }
+
+      // Verify results
+      Assert.Contains("Argument 'nonsense' not recognized. Must be one of:\t'MissingAll'\t'MissingAny'\t'None'", standardError);
+    }
+
+    [Theory]
+    [InlineData("MissingAll")]
+    [InlineData("MissingAny")]
+    [InlineData("None")]
+    public void ExcludeAssembliesWithoutSources_DifferentModes(string mode)
+    {
+      using ClonedTemplateProject clonedTemplateProject = CloneTemplateProject();
+      UpdateNugetConfigWithLocalPackageFolder(clonedTemplateProject.ProjectRootPath!);
+      string coverletToolCommandPath = InstallTool(clonedTemplateProject.ProjectRootPath!);
+      string outputPath = $"{clonedTemplateProject.ProjectRootPath}{Path.DirectorySeparatorChar}coverage.json";
+
+      // Build the test project
+      DotnetCli($"build -f {_buildTargetFramework} {clonedTemplateProject.ProjectRootPath}",
+          out string buildOutput,
+          out string buildError);
+
+      string publishedTestFile = clonedTemplateProject.GetFiles("*" + ClonedTemplateProject.AssemblyName + ".dll")
+          .Single(f => !f.Contains("obj") && !f.Contains("ref"));
+
+      // Run coverage with different exclude-assemblies-without-sources modes
+      int cmdExitCode = RunCommand(
+          coverletToolCommandPath,
+          $"\"{publishedTestFile}\" --target \"dotnet\" " +
+          $"--targetargs \"test {Path.Combine(clonedTemplateProject.ProjectRootPath, ClonedTemplateProject.ProjectFileName)} --no-build\" " +
+          $"--exclude-assemblies-without-sources {mode} " +
+          $"--output \"{outputPath}\"",
+          out string standardOutput,
+          out string standardError);
+
+      if (!string.IsNullOrEmpty(standardError))
+      {
+        _output.WriteLine(standardError);
+      }
+      else
+      {
+        _output.WriteLine(standardOutput);
+      }
+
+      // Verify basic execution
+      Assert.Empty(standardError);
+      Assert.True(File.Exists(outputPath), "Coverage output file should exist");
+      Assert.Equal((int)CommandExitCodes.Success, cmdExitCode);
+      Assert.Contains("Passed!", standardOutput);
+    }
   }
 }