[issues/162] Add BookmarksStore for cross-workspace bookmark persistence (#184)

* Introduce `BookmarkStore` and tests

* Integrate `BookmarksStore` in `extension.ts`

* Bring `nanoid` dependency to avoid relying on `node:crypto` that might not be there for older vscode versions

* Ran `format:fix`

* Avoid repetition for default empty structure (in a functional-leaning friendly way)

* Simplify constructor

* Bookmark-persisting operations are now async instead of silently swallowing the potential errors

* Cleanup comments

* Create and export `createIsoTimestamp()`

* Centralize type definition

* Centralize timestamp generation

* Introduced `BookmarkId` type

* Introduce `findBookmarkIndex()` to decreaser copy-pasta

* Update `import`s

* Majoir test updates; I need to scrutinize them…

* Adding a bookmark now logs the whole object

* Bookmark-handling methods now log the whole bookmark object to produce richer logs

* Ran `format:fix`

* Externalize `createMockMemento()` to align with other test helpers

* BookmarkStore now throws an error when it can successfully initialize

Summary of changes:
  - Constructor now throws BOOKMARK_STORE_NOT_AVAILABLE error when globalState is undefined
  - Removed defensive null checks in load() and save() - no longer needed
  - Updated globalState parameter type from GlobalStateWithSync | undefined to GlobalStateWithSync

  This fail-fast approach ensures the extension knows immediately if bookmarks won't work, rather than silently failing later.

* Create cleaner `context` in tests

* Decrease copy-pasta in new tests by better organizing root-level variables

* Decreased copy-pasta in tests to simplify setups

* Bookmark id generation is now collision-safe and has a cap of 10 retries max (with unique error code on failure)

* Update `BookmarkStore` to return `Result`s

This converted the code to stop throwing errors. At the same time, introduced `toBeRangeLinkExtensionErrorErr()` custom matcher that we didn’t yet have.

Also added `BOOKMARK_NOT_FOUND` error code

* Constructor and persistence-related methods now log `syncEnabled` attribute

* Logging must be tested within each method as normal flow

* Tests must freeze the contract instead of using constants

* Updating a bookmark logs the original one

Author: couimet

packages/rangelink-vscode-extension/jest.config.js

@@ -28,6 +28,8 @@ module.exports = {
   },
   moduleNameMapper: {
     '^vscode$': '<rootDir>/src/__tests__/__mocks__/vscode',
+    // Mock nanoid (ESM-only package) - tests use injected IdGenerator anyway
+    '^nanoid$': '<rootDir>/src/__tests__/__mocks__/nanoid.ts',
   },
   transform: {
     '^.+\\.ts$': 'ts-jest',

packages/rangelink-vscode-extension/package.json

@@ -267,6 +267,7 @@
   ],
   "dependencies": {
     "barebone-logger": "workspace:*",
+    "nanoid": "^5.1.6",
     "rangelink-core-ts": "workspace:*"
   },
   "devDependencies": {

packages/rangelink-vscode-extension/src/__tests__/__mocks__/nanoid.ts

@@ -0,0 +1,13 @@
+/**
+ * Mock for nanoid package.
+ * nanoid is ESM-only and doesn't work with Jest's CommonJS transform.
+ * Production code uses the real nanoid via esbuild bundling.
+ * Tests use IdGenerator injection, so this mock just needs to export a valid function.
+ */
+
+let counter = 0;
+
+export const nanoid = (): string => {
+  counter++;
+  return `mock-nanoid-${counter.toString().padStart(4, '0')}`;
+};