Skip to content
  • Sponsor coreui/coreui-angular

  • Notifications You must be signed in to change notification settings
  • Fork 152

Commit a9a2abb

Browse files
authoredJun 7, 2019
Merge pull request #65 from coreui/fix-remove-html-attribute
v2.5.1
2 parents eda88a2 + ccb601f commit a9a2abb

File tree

16 files changed

+220
-134
lines changed

16 files changed

+220
-134
lines changed
 

‎CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
### [@coreui/angular](https://coreui.io/) changelog
22

3+
##### `v2.5.1`
4+
- fix(appHtmlAttr): cannot remove html attribute,
5+
ex: `attributes: {hidden: null}` removes attribute `hidden`
6+
7+
###### dependencies update
8+
- update `@angular-devkit/build-angular` to `^0.800.2`
9+
- update `@angular-devkit/build-ng-packagr` to `^0.800.2`
10+
- update `@angular/cli` to `^8.0.2`
11+
- update `ng-packagr` to `^5.3.0`
12+
313
##### `v2.5.0`
414
- chore: upgrade to Angular 8.0 - thanks @dennisameling
515
- chore: move browserslist file

‎dist/@coreui/angular/bundles/coreui-angular.umd.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/bundles/coreui-angular.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/bundles/coreui-angular.umd.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/bundles/coreui-angular.umd.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/esm2015/lib/shared/layout/layout.directive.js

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/esm5/lib/shared/layout/layout.directive.js

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/fesm2015/coreui-angular.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/fesm2015/coreui-angular.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/fesm5/coreui-angular.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/fesm5/coreui-angular.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/@coreui/angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coreui/angular",
3-
"version": "2.5.0",
3+
"version": "2.5.1",
44
"description": "CoreUI Angular Bootstrap 4 components",
55
"license": "MIT",
66
"homepage": "https://coreui.io/angular",

‎package-lock.json

Lines changed: 178 additions & 114 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coreui/angular-dev",
3-
"version": "2.5.0",
3+
"version": "2.5.1",
44
"license": "MIT",
55
"author": {
66
"name": "Łukasz Holeczek",
@@ -41,9 +41,9 @@
4141
"zone.js": "~0.9.1"
4242
},
4343
"devDependencies": {
44-
"@angular-devkit/build-angular": "~0.800.1",
45-
"@angular-devkit/build-ng-packagr": "~0.800.1",
46-
"@angular/cli": "^8.0.1",
44+
"@angular-devkit/build-angular": "^0.800.2",
45+
"@angular-devkit/build-ng-packagr": "^0.800.2",
46+
"@angular/cli": "^8.0.2",
4747
"@angular/compiler-cli": "^8.0.0",
4848
"@angular/language-service": "^8.0.0",
4949
"@types/jasmine": "^3.3.13",
@@ -57,7 +57,7 @@
5757
"karma-coverage-istanbul-reporter": "^2.0.5",
5858
"karma-jasmine": "~2.0.1",
5959
"karma-jasmine-html-reporter": "^1.4.0",
60-
"ng-packagr": "^5.2.0",
60+
"ng-packagr": "^5.3.0",
6161
"protractor": "^5.4.2",
6262
"shelljs": "^0.8.3",
6363
"ts-node": "^8.0.3",

‎projects/coreui/angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coreui/angular",
3-
"version": "2.5.0",
3+
"version": "2.5.1",
44
"description": "CoreUI Angular Bootstrap 4 components",
55
"license": "MIT",
66
"homepage": "https://coreui.io/angular",

‎projects/coreui/angular/src/lib/shared/layout/layout.directive.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,8 @@ export class HtmlAttributesDirective implements OnInit {
169169
}
170170

171171
private setAttrib(key, value) {
172-
this.renderer.setAttribute(this.el.nativeElement, key, value );
172+
value !== null ?
173+
this.renderer.setAttribute(this.el.nativeElement, key, value ) :
174+
this.renderer.removeAttribute(this.el.nativeElement, key);
173175
}
174176
}

0 commit comments

Comments
 (0)
Please sign in to comment.