Skip to content

Commit d158fab

Browse files
feat: dallin feedback pt 2
1 parent 33b1d39 commit d158fab

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

core/config/profile/doLoadConfig.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,26 @@ export default async function doLoadConfig(options: {
219219
}
220220
});
221221

222+
const ruleCounts: Record<string, number> = {};
223+
newConfig.rules.forEach((rule) => {
224+
if (rule.name) {
225+
if (ruleCounts[rule.name]) {
226+
ruleCounts[rule.name] = ruleCounts[rule.name] + 1;
227+
} else {
228+
ruleCounts[rule.name] = 1;
229+
}
230+
}
231+
});
232+
233+
Object.entries(ruleCounts).forEach(([ruleName, count]) => {
234+
if (count > 1) {
235+
errors!.push({
236+
fatal: false,
237+
message: `Duplicate (${count}) rules named "${ruleName}" detected. This may cause unexpected behavior`,
238+
});
239+
}
240+
});
241+
222242
newConfig.allowAnonymousTelemetry =
223243
newConfig.allowAnonymousTelemetry && (await ide.isTelemetryEnabled());
224244

gui/src/redux/slices/uiSlice.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const uiSlice = createSlice({
5656
[BuiltInToolNames.ViewDiff]: "allowedWithoutPermission",
5757
[BuiltInToolNames.LSTool]: "allowedWithoutPermission",
5858
[BuiltInToolNames.CreateRuleBlock]: "allowedWithPermission",
59-
[BuiltInToolNames.RequestRule]: "allowedWithPermission",
59+
[BuiltInToolNames.RequestRule]: "disabled",
6060
},
6161
toolGroupSettings: {
6262
[BUILT_IN_GROUP_NAME]: "include",

0 commit comments

Comments
 (0)