Skip to content

Commit 188a919

Browse files
harshithad0703harshithad0703
authored
Merge pull request #83 from contentstack/refactor/DX-1473
refactor: Updating to system.text.json
2 parents af57f3a + 3ac6f95 commit 188a919

17 files changed

+214
-172
lines changed

‎.github/workflows/jira.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
project: ${{ secrets.JIRA_PROJECT }}
2222
issuetype: ${{ secrets.JIRA_ISSUE_TYPE }}
2323
summary: |
24-
${{ github.event.pull_request.title }}
24+
Snyk | Vulnerability | ${{ github.event.repository.name }} | ${{ github.event.pull_request.title }}
2525
description: |
2626
PR: ${{ github.event.pull_request.html_url }}
2727

‎.github/workflows/sca-scan.yml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,10 @@ jobs:
66
security-sca:
77
runs-on: ubuntu-latest
88
steps:
9-
- name: Checkout repository
10-
uses: actions/checkout@master
11-
- name: Setup .NET Core @ Latest
12-
uses: actions/setup-dotnet@v1
13-
with:
14-
dotnet-version: "7.0.x"
15-
- name: Run Dotnet Restore
16-
run: |
17-
dotnet restore
9+
- uses: actions/checkout@master
1810
- name: Run Snyk to check for vulnerabilities
1911
uses: snyk/actions/dotnet@master
2012
env:
2113
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
2214
with:
23-
args: --file=Contentstack.Core/obj/project.assets.json --fail-on=all
15+
args: --fail-on=all

‎.talismanrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
fileignoreconfig:
22
- filename: Contentstack.Core/Internals/HttpRequestHandler.cs
3-
checksum: 93c1659f3bc7527956f0fd12db46441297fac3a4366d273bcbb3425d2351300e
3+
checksum: 29bb8548d65cdc5800fc939e526797bb3515f528d8082a58a0c9c6215dec1651
44
- filename: Contentstack.Core/Models/Entry.cs
55
checksum: 79320b005882981fd7c79fe73832f28284db686927942e46b422ac9e88405023
66
- filename: Contentstack.Core/ContentstackClient.cs

‎CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @contentstack/security-admin
1+
* @contentstack/security-admin

‎Contentstack.Core/Configuration/LivePreviewConfig.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using System;
2-
using System.Collections;
3-
using Newtonsoft.Json.Linq;
1+
using System.Text.Json;
42

53
namespace Contentstack.Core.Configuration
64
{
@@ -13,6 +11,6 @@ public class LivePreviewConfig
1311
internal string LivePreview { get; set; }
1412
internal string ContentTypeUID { get; set; }
1513
internal string EntryUID { get; set; }
16-
internal JObject PreviewResponse { get; set; }
14+
internal JsonElement PreviewResponse { get; set; }
1715
}
1816
}

‎Contentstack.Core/Contentstack.Core.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFrameworks>netstandard2.0;net47;net472;</TargetFrameworks>
4+
<TargetFrameworks>net7.0</TargetFrameworks>
55
<PackageId>contentstack.csharp</PackageId>
66
<Authors>Contentstack</Authors>
77
<Description>.NET SDK for the Contentstack Content Delivery API.</Description>
@@ -28,7 +28,6 @@
2828
<AllowUnsafeBlocks></AllowUnsafeBlocks>
2929
</PropertyGroup>
3030
<ItemGroup>
31-
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
3231
<PackageReference Include="Microsoft.Extensions.Options" Version="8.0.2" />
3332
<PackageReference Include="Markdig" Version="0.36.2" />
3433
<PackageReference Include="contentstack.utils" Version="1.0.5" />

‎Contentstack.Core/ContentstackClient.cs

Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
using System;
2+
using System.Collections;
23
using System.Collections.Generic;
3-
using Contentstack.Core.Internals;
4-
using Contentstack.Core.Configuration;
5-
using Microsoft.Extensions.Options;
6-
using Contentstack.Core.Models;
7-
using Newtonsoft.Json.Linq;
8-
using Newtonsoft.Json;
4+
using System.IO;
95
using System.Linq;
10-
using System.Threading.Tasks;
116
using System.Net;
12-
using System.IO;
13-
using System.Collections;
14-
using Contentstack.Utils;
7+
using System.Text.Json;
8+
using System.Text.Json.Serialization;
9+
using System.Threading.Tasks;
10+
using Contentstack.Core.Configuration;
1511
using Contentstack.Core.Interfaces;
12+
using Contentstack.Core.Internals;
13+
using Contentstack.Core.Models;
14+
using Microsoft.Extensions.Options;
1615

1716
namespace Contentstack.Core
1817
{
@@ -24,7 +23,16 @@ public class ContentstackClient
2423
/// <summary>
2524
/// Gets or sets the settings that should be used for deserialization.
2625
/// </summary>
27-
public JsonSerializerSettings SerializerSettings { get; set; } = new JsonSerializerSettings();
26+
public JsonSerializerOptions SerializerSettings { get; set; } = new JsonSerializerOptions
27+
{
28+
PropertyNameCaseInsensitive = true,
29+
DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull,
30+
Converters = {
31+
new JsonStringEnumConverter(),
32+
new CustomUtcDateTimeConverter(),
33+
new CustomNullableUtcDateTimeConverter(),
34+
}
35+
};
2836

2937
#region Internal Variables
3038

@@ -35,7 +43,6 @@ internal string StackApiKey
3543
}
3644
private ContentstackOptions _options;
3745

38-
internal JsonSerializer Serializer => JsonSerializer.Create(SerializerSettings);
3946
internal string _SyncUrl
4047
{
4148
get
@@ -133,10 +140,6 @@ public ContentstackClient(IOptions<ContentstackOptions> options)
133140
throw new InvalidOperationException("Add PreviewToken or ManagementToken in LivePreviewConfig");
134141
}
135142
}
136-
this.SerializerSettings.DateParseHandling = DateParseHandling.None;
137-
this.SerializerSettings.DateFormatHandling = DateFormatHandling.IsoDateFormat;
138-
this.SerializerSettings.DateTimeZoneHandling = DateTimeZoneHandling.Utc;
139-
this.SerializerSettings.NullValueHandling = NullValueHandling.Ignore;
140143

141144
foreach (Type t in CSJsonConverterAttribute.GetCustomAttribute(typeof(CSJsonConverterAttribute)))
142145
{
@@ -209,22 +212,18 @@ internal static ContentstackException GetContentstackError(Exception ex)
209212
using (var reader = new StreamReader(stream))
210213
{
211214
errorMessage = reader.ReadToEnd();
212-
JObject data = JObject.Parse(errorMessage.Replace("\r\n", ""));
215+
var data = JsonSerializer.Deserialize<JsonElement>(errorMessage);
213216

214-
JToken token = data["error_code"];
215-
if (token != null)
216-
errorCode = token.Value<int>();
217+
if (data.TryGetProperty("error_code", out var token))
218+
errorCode = token.GetInt32();
217219

218-
token = data["error_message"];
219-
if (token != null)
220-
errorMessage = token.Value<string>();
220+
if (data.TryGetProperty("error_message", out token))
221+
errorMessage = token.GetString();
221222

222-
token = data["errors"];
223-
if (token != null)
224-
errors = token.ToObject<Dictionary<string, object>>();
223+
if (data.TryGetProperty("errors", out token))
224+
errors = JsonSerializer.Deserialize<Dictionary<string, object>>(token.GetRawText());
225225

226-
var response = exResp as HttpWebResponse;
227-
if (response != null)
226+
if (exResp is HttpWebResponse response)
228227
statusCode = response.StatusCode;
229228
}
230229
}
@@ -326,8 +325,8 @@ public async Task<IList> GetContentTypes(Dictionary<string, object> param = null
326325
{
327326
HttpRequestHandler RequestHandler = new HttpRequestHandler(this);
328327
var outputResult = await RequestHandler.ProcessRequest(_Url, headers, mainJson, Branch: this.Config.Branch, timeout: this.Config.Timeout, proxy: this.Config.Proxy);
329-
JObject data = JsonConvert.DeserializeObject<JObject>(outputResult.Replace("\r\n", ""), this.SerializerSettings);
330-
IList contentTypes = (IList)data["content_types"];
328+
var data = JsonSerializer.Deserialize<JsonElement>(outputResult);
329+
var contentTypes = data.GetProperty("content_types").EnumerateArray().ToList();
331330
return contentTypes;
332331
}
333332
catch (Exception ex)
@@ -336,7 +335,7 @@ public async Task<IList> GetContentTypes(Dictionary<string, object> param = null
336335
}
337336
}
338337

339-
private async Task<JObject> GetLivePreviewData()
338+
private async Task<JsonElement> GetLivePreviewData()
340339
{
341340

342341
Dictionary<String, object> headerAll = new Dictionary<string, object>();
@@ -368,8 +367,8 @@ private async Task<JObject> GetLivePreviewData()
368367
{
369368
HttpRequestHandler RequestHandler = new HttpRequestHandler(this);
370369
var outputResult = await RequestHandler.ProcessRequest(String.Format("{0}/content_types/{1}/entries/{2}", this.Config.getLivePreviewUrl(this.LivePreviewConfig), this.LivePreviewConfig.ContentTypeUID, this.LivePreviewConfig.EntryUID), headerAll, mainJson, Branch: this.Config.Branch, isLivePreview: true, timeout: this.Config.Timeout, proxy: this.Config.Proxy);
371-
JObject data = JsonConvert.DeserializeObject<JObject>(outputResult.Replace("\r\n", ""), this.SerializerSettings);
372-
return (JObject)data["entry"];
370+
var data = JsonSerializer.Deserialize<JsonElement>(outputResult);
371+
return data.GetProperty("entry");
373372
}
374373
catch (Exception ex)
375374
{
@@ -786,7 +785,7 @@ private async Task<SyncStack> GetResultAsync(string Init = "false", SyncType Syn
786785
{
787786
HttpRequestHandler requestHandler = new HttpRequestHandler(this);
788787
string js = await requestHandler.ProcessRequest(_SyncUrl, _LocalHeaders, mainJson, Branch: this.Config.Branch, timeout: this.Config.Timeout, proxy: this.Config.Proxy);
789-
SyncStack stackSyncOutput = JsonConvert.DeserializeObject<SyncStack>(js);
788+
SyncStack stackSyncOutput = JsonSerializer.Deserialize<SyncStack>(js);
790789
return stackSyncOutput;
791790
}
792791
catch (Exception ex)

‎Contentstack.Core/Internals/AssetJsonConverter.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
using System;
2-
using Contentstack.Core;
2+
using System.Text.Json;
3+
using System.Text.Json.Serialization;
34
using Contentstack.Core.Models;
4-
using Newtonsoft.Json;
5-
using Newtonsoft.Json.Linq;
65

76
namespace Contentstack.Core.Internals
87
{
98
[CSJsonConverter("AssetJsonConverter")]
109
public class AssetJsonConverter : JsonConverter<Asset>
1110
{
12-
public override Asset ReadJson(JsonReader reader, Type objectType, Asset existingValue, bool hasExistingValue, JsonSerializer serializer)
11+
public override Asset Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
1312
{
14-
JObject jObject = JObject.Load(reader);
15-
JsonSerializerSettings SerializerSettings = new JsonSerializerSettings();
16-
JsonSerializer Serializer = JsonSerializer.Create(SerializerSettings);
17-
Asset asset = jObject.ToObject<Asset>(Serializer);
18-
asset.ParseObject(jObject);
19-
return asset;
13+
using (JsonDocument document = JsonDocument.ParseValue(ref reader))
14+
{
15+
JsonElement root = document.RootElement;
16+
Asset asset = JsonSerializer.Deserialize<Asset>(root.GetRawText(), options);
17+
asset.ParseObject(root);
18+
return asset;
19+
}
2020
}
2121

22-
public override void WriteJson(JsonWriter writer, Asset value, JsonSerializer serializer)
22+
public override void Write(Utf8JsonWriter writer, Asset value, JsonSerializerOptions options)
2323
{
2424
throw new NotImplementedException();
2525
}
2626
}
27-
}
27+
}

‎Contentstack.Core/Internals/ContentStackError.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
using Newtonsoft.Json;
2-
using System;
1+
using System;
32
using System.Collections.Generic;
43
using System.Net;
5-
4+
using System.Text.Json.Serialization;
5+
66
namespace Contentstack.Core.Internals
77
{
88
/// <summary>
@@ -33,7 +33,7 @@ public class ContentstackException : Exception
3333
/// <summary>
3434
/// This is error message.
3535
/// </summary>
36-
[JsonProperty("error_message")]
36+
[JsonPropertyName("error_message")]
3737
public string ErrorMessage
3838
{
3939
get
@@ -50,13 +50,13 @@ public string ErrorMessage
5050
/// <summary>
5151
/// This is error code.
5252
/// </summary>
53-
[JsonProperty("error_code")]
53+
[JsonPropertyName("error_code")]
5454
public int ErrorCode { get; set; }
5555

5656
/// <summary>
5757
/// Set of errors in detail.
5858
/// </summary>
59-
[JsonProperty("errors")]
59+
[JsonPropertyName("errors")]
6060
public Dictionary<string, object> Errors { get; set; }
6161

6262
#endregion

‎Contentstack.Core/Internals/ContentstackConvert.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
1-
using Newtonsoft.Json;
2-
using System;
1+
using System;
32
using System.IO;
4-
using System.Net.NetworkInformation;
5-
using System.Security.Cryptography;
6-
using System.Text;
73
using System.Text.RegularExpressions;
84

95
namespace Contentstack.Core.Internals

‎Contentstack.Core/Internals/HttpRequestHandler.cs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
using System.Linq;
55
using System.Net;
66
using System.Text;
7+
using System.Text.Json;
8+
using System.Text.Json.Nodes;
79
using System.Threading.Tasks;
8-
using Newtonsoft.Json;
9-
using Newtonsoft.Json.Linq;
1010

1111
namespace Contentstack.Core.Internals
1212
{
@@ -35,7 +35,7 @@ public async Task<string> ProcessRequest(string Url, Dictionary<string, object>
3535
return value;
3636
}
3737
else if (kvp.Value is Dictionary<string, object>)
38-
value = JsonConvert.SerializeObject(kvp.Value);
38+
value = JsonSerializer.Serialize(kvp.Value);
3939
else
4040
return String.Format("{0}={1}", kvp.Key, kvp.Value);
4141

@@ -75,7 +75,7 @@ public async Task<string> ProcessRequest(string Url, Dictionary<string, object>
7575
request = await plugin.OnRequest(client, request);
7676
};
7777

78-
var serializedresult = JsonConvert.SerializeObject(BodyJson);
78+
var serializedresult = JsonSerializer.Serialize(BodyJson);
7979
byte[] requestBody = Encoding.UTF8.GetBytes(serializedresult);
8080
StreamReader reader = null;
8181
HttpWebResponse response = null;
@@ -108,42 +108,42 @@ public async Task<string> ProcessRequest(string Url, Dictionary<string, object>
108108

109109
}
110110

111-
internal void updateLivePreviewContent(JObject response)
111+
internal void updateLivePreviewContent(JsonObject response)
112112
{
113113
if (response.ContainsKey("uid") && response["uid"].ToString() == this.client.LivePreviewConfig.EntryUID)
114114
{
115-
response.Merge(this.client.LivePreviewConfig.PreviewResponse, new JsonMergeSettings()
115+
foreach (var property in this.client.LivePreviewConfig.PreviewResponse.AsObject())
116116
{
117-
MergeArrayHandling = MergeArrayHandling.Replace
118-
});
117+
response[property.Key] = property.Value;
118+
}
119119
}
120120
else
121121
{
122122
foreach (var content in response)
123123
{
124-
if (content.Value.Type == JTokenType.Array)
124+
if (content.Value is JsonArray)
125125
{
126-
updateArray((JArray)response[content.Key]);
126+
updateArray((JsonArray)response[content.Key]);
127127
}
128-
else if (content.Value.Type == JTokenType.Object)
128+
else if (content.Value is JsonObject)
129129
{
130-
updateLivePreviewContent((JObject)response[content.Key]);
130+
updateLivePreviewContent((JsonObject)response[content.Key]);
131131
}
132132
}
133133
}
134134
}
135135

136-
internal void updateArray(JArray array)
136+
internal void updateArray(JsonArray array)
137137
{
138138
for (var i = 0; i < array.Count(); i++)
139139
{
140-
if (array[i].Type == JTokenType.Array)
140+
if (array[i] is JsonArray)
141141
{
142-
updateArray((JArray)array[i]);
142+
updateArray((JsonArray)array[i]);
143143
}
144-
else if (array[i].Type == JTokenType.Object)
144+
else if (array[i] is JsonObject)
145145
{
146-
updateLivePreviewContent((JObject)array[i]);
146+
updateLivePreviewContent((JsonObject)array[i]);
147147
}
148148
}
149149
}

0 commit comments

Comments
 (0)