feat: print client info from podman version when the server is not available#28265
Open
kyounghunJang wants to merge 1 commit intocontainers:mainfrom
Open
feat: print client info from podman version when the server is not available#28265kyounghunJang wants to merge 1 commit intocontainers:mainfrom
podman version when the server is not available#28265kyounghunJang wants to merge 1 commit intocontainers:mainfrom
Conversation
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
danishprakash
approved these changes
Mar 12, 2026
Honny1
reviewed
Mar 12, 2026
Member
Honny1
left a comment
Honny1
left a comment
There was a problem hiding this comment.
Thanks! I have a few comments regarding the tests, but otherwise, LGTM.
…ailable In remote mode, `podman version` currently returns a connection error before printing any version information if it cannot connect to the service. Introduce a reusable `PrintVersion` helper and invoke it at the root level when a `ConnectionError` is encountered. This ensures that client information is still shown even when the server cannot be reached. Fixes: containers#28222 Signed-off-by: KyounghoonJang <matkimchi_@naver.com>
Member
|
@danishprakash Does your approval count as an LGTM? |
TomSweeneyRedHat
changed the title
podman version when the server is ailablepodman version when the server is not available
Member
|
I think the title "feat: print client info from podman version when the server is ailable" should be "feat: print client info from podman version when the server is not available" and have changed it. Holler if that is incorrect. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
In remote mode,
podman versioncurrently returns a connection error before printing any version information if it cannot connect to the service.Introduce a reusable
PrintVersionhelper and invoke it at the root level when aConnectionErroris encountered. This ensures that client information is still shown even when the server cannot be reached.Before
After
Fixes: #28222
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?