Add missing controller tests for adding and removing maintainer

Author: stevenrombauts

tests/Controller/PackageControllerTest.php

@@ -12,6 +12,9 @@
 
 namespace App\Tests\Controller;
 
+use App\Audit\AuditRecordType;
+use App\Entity\Package;
+use App\Entity\User;
 use App\Tests\IntegrationTestCase;
 
 class PackageControllerTest extends IntegrationTestCase
@@ -52,4 +55,93 @@ public function testEdit(): void
         self::assertResponseIsSuccessful();
         self::assertSame('github.com/composer/composer', $crawler->filter('.canonical')->text());
     }
+
+    public function testCreateMaintainer(): void
+    {
+        $owner = self::createUser('owner', '[email protected]');
+        $newMaintainer = self::createUser('maintainer', '[email protected]');
+        $package = self::createPackage('test/pkg', 'https://example.com/test/pkg', maintainers: [$owner]);
+
+        $this->store($owner, $newMaintainer, $package);
+
+        $this->client->loginUser($owner);
+
+        $this->assertFalse($package->isMaintainer($newMaintainer));
+
+        $crawler = $this->client->request('GET', '/packages/test/pkg');
+
+        $form = $crawler->filter('[name="add_maintainer_form"]')->form();
+        $form->setValues([
+            'add_maintainer_form[user]' => 'maintainer',
+        ]);
+
+        $this->client->enableProfiler(); // This is required in 7.3.4 to assert emails were sent, see https://github.com/symfony/symfony/issues/61873
+        $this->client->submit($form);
+
+        $this->assertEmailCount(1);
+        $email = $this->getMailerMessage();
+        $this->assertNotNull($email);
+        $this->assertEmailHeaderSame($email, 'To', $newMaintainer->getEmail());
+
+        $this->assertResponseRedirects('/packages/test/pkg');
+        $this->client->followRedirect();
+        $this->assertResponseIsSuccessful();
+
+        $em = self::getEM();
+        $em->clear();
+
+        $maintainer = $em->getRepository(User::class)->find($newMaintainer->getId());
+        $package = $em->getRepository(Package::class)->find($package->getId());
+
+        $this->assertTrue($package->isMaintainer($maintainer));
+
+        $auditRecord = $em->getRepository(\App\Entity\AuditRecord::class)->findOneBy([
+            'type' => AuditRecordType::MaintainerAdded->value,
+            'packageId' => $package->getId(),
+            'actorId' => $owner->getId(),
+        ]);
+        $this->assertNotNull($auditRecord);
+    }
+
+    public function testRemoveMaintainer(): void
+    {
+        $owner = self::createUser('owner', '[email protected]');
+        $maintainer = self::createUser('maintainer', '[email protected]');
+        $package = self::createPackage('test/pkg', 'https://example.com/test/pkg', maintainers: [$owner, $maintainer]);
+
+        $this->store($owner, $maintainer, $package);
+
+        $this->client->loginUser($owner);
+
+        $this->assertTrue($package->isMaintainer($maintainer));
+
+        $crawler = $this->client->request('GET', '/packages/test/pkg');
+
+        $form = $crawler->filter('[name="remove_maintainer_form"]')->form();
+        $form->setValues([
+            'remove_maintainer_form[user]' => $maintainer->getId(),
+        ]);
+
+        $this->client->submit($form);
+
+        $this->assertResponseRedirects('/packages/test/pkg');
+        $this->client->followRedirect();
+        $this->assertResponseIsSuccessful();
+
+        $em = self::getEM();
+        $em->clear();
+
+        $maintainer = $em->getRepository(User::class)->find($maintainer->getId());
+        $package = $em->getRepository(Package::class)->find($package->getId());
+
+        $this->assertFalse($package->isMaintainer($maintainer));
+
+        $auditRecord = $em->getRepository(\App\Entity\AuditRecord::class)->findOneBy([
+            'type' => AuditRecordType::MaintainerRemoved->value,
+            'packageId' => $package->getId(),
+            'actorId' => $owner->getId(),
+        ]);
+
+        $this->assertNotNull($auditRecord);
+    }
 }