Skip to content

Commit 17d1057

Browse files
authored
Merge pull request #523 from components-ai/remove-actions-up-down
Removes up / down reorder actions since we have drag and drop now
2 parents 11ed271 + d9dfabe commit 17d1057

File tree

3 files changed

+2
-60
lines changed

3 files changed

+2
-60
lines changed

packages/gui/src/components/FieldArray.tsx

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import produce from 'immer'
21
import { useState } from 'react'
3-
import { flip, replace, remove, insert } from '../lib/array'
2+
import { replace, remove, insert } from '../lib/array'
43
import { EditorPropsWithLabel } from '../types/editor'
54
import { SchemaInput } from './inputs/SchemaInput'
65
import { DataTypeSchema } from './schemas/types'
@@ -21,13 +20,6 @@ export default function FieldArray<T>(props: FieldArrayProps<T>) {
2120
const [dragIndex, setDragIndex] = useState(-1)
2221
const isDragging = dragIndex >= 0
2322

24-
const handleReorder = (i1: number, i2: number) => {
25-
if (typeof value === 'string') {
26-
return
27-
}
28-
onChange(flip(value, i1, i2))
29-
}
30-
3123
const handleDragDrop = (i1: number, i2: number) => {
3224
const item = value[i1]
3325
const removed = remove(value, i1)
@@ -74,20 +66,6 @@ export default function FieldArray<T>(props: FieldArrayProps<T>) {
7466
onDragEnd={() => {
7567
setDragIndex(-1)
7668
}}
77-
reorder={{
78-
onMoveUp:
79-
i === 0
80-
? undefined
81-
: () => {
82-
handleReorder(i, i - 1)
83-
},
84-
onMoveDown:
85-
i === value.length - 1
86-
? undefined
87-
: () => {
88-
handleReorder(i, i + 1)
89-
},
90-
}}
9169
/>
9270
</div>
9371
</div>

packages/gui/src/components/inputs/SchemaInput.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ interface Props<T> {
1414
onRemove?(): void
1515
onDrag?(): void
1616
onDragEnd?(): void
17-
reorder?: {
18-
onMoveUp?(): void
19-
onMoveDown?(): void
20-
}
2117
}
2218

2319
/**

packages/gui/src/components/ui/InputHeader.tsx

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import { ReactNode } from 'react'
2-
import {
3-
AlignJustify,
4-
ChevronDown,
5-
ChevronUp,
6-
RefreshCw,
7-
X,
8-
} from 'react-feather'
2+
import { AlignJustify, RefreshCw, X } from 'react-feather'
93
import { EditorPropsWithLabel } from '../../types/editor'
104
import { Label } from '../primitives'
115
import { useTheme } from '../providers/ThemeContext'
@@ -16,10 +10,6 @@ interface Props extends Omit<EditorPropsWithLabel<any>, 'keywords'> {
1610
regenerate?(options: any): any
1711
onDrag?(): void
1812
onDragEnd?(): void
19-
reorder?: {
20-
onMoveUp?(): void
21-
onMoveDown?(): void
22-
}
2313
}
2414

2515
export function InputHeader({
@@ -31,7 +21,6 @@ export function InputHeader({
3121
onDrag,
3222
onDragEnd,
3323
regenerate,
34-
reorder,
3524
ruleset,
3625
property,
3726
}: Props) {
@@ -72,27 +61,6 @@ export function InputHeader({
7261
</IconButton>
7362
)}
7463
{onRemove && <DeleteButton onRemove={onRemove} />}
75-
{reorder && (
76-
<div
77-
sx={{
78-
display: 'flex',
79-
flexDirection: 'column',
80-
justifySelf: 'right',
81-
alignSelf: 'center',
82-
gap: '-0.5rem',
83-
}}
84-
>
85-
<IconButton disabled={!reorder.onMoveUp} onClick={reorder.onMoveUp}>
86-
<ChevronUp size={16} />
87-
</IconButton>
88-
<IconButton
89-
disabled={!reorder.onMoveDown}
90-
onClick={reorder.onMoveDown}
91-
>
92-
<ChevronDown size={16} />
93-
</IconButton>
94-
</div>
95-
)}
9664
</div>
9765
</div>
9866
)

0 commit comments

Comments
 (0)