Run browser tests on Windows #674
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
=======================================
Coverage 79.25% 79.25%
=======================================
Files 9 9
Lines 3866 3866
=======================================
Hits 3064 3064
Misses 802 802 🚀 New features to boost your workflow:
|
|
I have now got the Emscripten browser tests working in Firefox on Windows. Just got to solve an issue with Chrome. |
mcbarton
force-pushed
the
Windows-browser-tests
branch
from
0014ab1 to
d01f45c
Compare
mcbarton
force-pushed
the
Windows-browser-tests
branch
from
cac2eca to
40b049d
Compare
mcbarton
changed the title
|
This PR is now ready for review. The one failing ci job is the same one failing on main, and has nothing to do with this PR. |
|
What is the issue with the osx failure? |
@vgvassilev That has nothing to do with this PR. It fails on main, and I don't know what causes it. Its not the latest commit to CppInterOp as initial thought by me. The only way I currently know how to fix that failing job on main is via the PR which reduces the shared library size, and I don't know how that fixes it, just that it does. |
|
This is error that main and every PR (except the reduced shared library PR) on top of main gets for the osx job https://github.com/compiler-research/CppInterOp/actions/runs/16330436372/job/46133751186?pr=674#step:15:149 |
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist