Skip to content

Commit 804c9a3

Browse files
Patrick McElhaneyPatrick McElhaney
authored andcommitted
fix(commit): allow backticks in commit message
Escapes backticks before passing the commit message to Git. Closes #105
1 parent e7c299b commit 804c9a3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/git/commit.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function commit(sh, repoPath, message, options, done) {
1313

1414
var alreadyEnded = false;
1515
let dedentedMessage = dedent(message);
16-
let escapedMessage = dedentedMessage.replace(/"/g, '\\"');
16+
let escapedMessage = dedentedMessage.replace(/"/g, '\\"').replace(/`/g, '\\`');
1717
let operatingSystemNormalizedMessage;
1818
// On windows we must use an array in gulp-git instead of a string because
1919
// command line parsing works differently

test/tests/commit.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ describe('commit', function() {
8080

8181
// SETUP
8282

83-
let dummyCommitMessage = `sip sip sippin' on some "sizzurp"`;
83+
let dummyCommitMessage = `sip \`sip\` sippin' on some "sizzurp"`;
8484

8585
// Describe a repo and some files to add and commit
8686
let repoConfig = {
@@ -118,7 +118,7 @@ describe('commit', function() {
118118

119119
});
120120

121-
121+
122122
it('should commit multiline messages', function(done) {
123123

124124
this.timeout(config.maxTimeout); // this could take a while

0 commit comments

Comments
 (0)