Skip to content

Use of version_provider doesn't add changed files on cz bump #1108

Closed
@kassi

Description

@kassi

Description

When using a custom version provider that changes some arbitrary file defined in the version provider itself, this file is not added to git on a cz bump.
Only files defined within version_files are added. However having to specify the file that is being changed within the version provider also inside version_files may lead to problems.

Steps to reproduce

  • Specify a version provider, e.g. commitizen_lrplugin or commitizen_ruby (without specifying the actual version file in version_files
  • bump the version with cz bump
  • run git status
  • see that the version file has not been committed.

Current behavior

The file with version number changed by the version provider is not added to the bump commit.

Desired behavior

The file with version number changed by the version provider should be automatically added to the bump commit.

Screenshots

No response

Environment

Commitizen Version: 3.25.0
Python Version: 3.12.3 (main, Apr 16 2024, 11:43:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]
Operating System: Darwin

Activity

woile

woile commented on May 15, 2024

@woile
Member

Is the file being tracked by git? commitizen does git commit -a which should include modified files during bump

kassi

kassi commented on May 17, 2024

@kassi
Author

@woile yes, it's tracked by git. I tested again and again and finally realized, that the file is being checked-in, but after the commit increasing the version number, some automatism updated itself in the lock file (Gemfile.lock in this case), raising the version number and making the repo dirty again. I'll close this issue and have to figure out what's causing this in the ruby environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Use of version_provider doesn't add changed files on cz bump · Issue #1108 · commitizen-tools/commitizen