Skip to content

Add RyeProvider to version providers. #1102

Closed
@tabassco

Description

@tabassco

Description

I'd like to support Rye (https://rye-up.com) to provide versioning.
It should be a simple addition as it utilizes the same pyproject.toml as poetry, etc.

I'll gladly implement this.

Possible Solution

Add RyeProvider class in providers module

Additional context

No response

Additional context

No response

Activity

Lee-W

Lee-W commented on May 13, 2024

@Lee-W
Member

Hi @tabassco , thanks for creating this issue. But we'd like to avoid adding new providers to the core. We'd encourage to create your own provider plugin and we'll be more than happy to mention your plugin in https://commitizen-tools.github.io/commitizen/third-party-commitizen/#installation_3. (This page should probably be updated a bit, though 🤔 )

woile

woile commented on May 13, 2024

@woile
Member

If my memory serves me well, rye uses the default parameters from [project], so the pep621 should work with rye for version management.
https://commitizen-tools.github.io/commitizen/config/#version-providers

Lee-W

Lee-W commented on May 13, 2024

@Lee-W
Member

@woile Looks like some of the detail is still different 🤔 https://github.com/commitizen-tools/commitizen/pull/1103/files

woile

woile commented on May 13, 2024

@woile
Member

I haven't found any rye repo using that configuration, even the default template from rye uses version from the [project]:
https://github.com/astral-sh/rye/blob/main/rye/src/templates/pyproject.toml.j2#L3

On top of that, running rye version -b minor also bumps the [project.version], not the tool.rye.version. I think the tool.rye.version points to the actual version of rye that you expect in the project (I couldn't find any docs about it though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Add RyeProvider to version providers. · Issue #1102 · commitizen-tools/commitizen