Skip to content

Commit 65a93f4

Browse files
committed
fix: CI 빌드 및 테스트 이슈 해결
- 모델 경로 변경 - 테스트 실패 수정
1 parent 0df645a commit 65a93f4

File tree

5 files changed

+36
-28
lines changed

5 files changed

+36
-28
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
__debug_bin
1919

20-
ModelGenerator/
20+
base/
2121
.idea/
2222
models/
2323
include/

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
KIWI_VERSION := "v0.21.0"
1+
KIWI_VERSION := v0.21.0
22

33
.PHONY: test
4-
test: ModelGenerator/default.dict
5-
go test -count=1 ./...
4+
test: base/default.dict
5+
go test ./...
66

7-
ModelGenerator/default.dict:
7+
base/default.dict:
88
curl -L https://github.com/bab2min/Kiwi/releases/download/$(KIWI_VERSION)/kiwi_model_$(KIWI_VERSION)_base.tgz --output model.tgz
9-
tar -xzvf model.tgz
9+
tar --no-same-owner -xzvf model.tgz
1010
rm -f model.tgz
1111

1212

@@ -17,7 +17,7 @@ install-kiwi:
1717
.PHONY: clean
1818
clean:
1919
rm -f model.tgz
20-
rm -rf ./ModelGenerator
20+
rm -rf ./base
2121

2222
.PHONY: format
2323
format:

kiwi_example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import (
77
)
88

99
func Example() {
10-
kb := kiwi.NewBuilder("./ModelGenerator", 1 /*=numThread*/, kiwi.KIWI_BUILD_INTEGRATE_ALLOMORPH /*=options*/)
10+
kb := kiwi.NewBuilder("./base", 1 /*=numThread*/, kiwi.KIWI_BUILD_INTEGRATE_ALLOMORPH /*=options*/)
1111
kb.AddWord("코딩냄비", "NNP", 0)
1212

1313
k := kb.Build()

kiwi_test.go

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ func TestKiwiVersion(t *testing.T) {
1313
}
1414

1515
func TestAnalyze(t *testing.T) {
16-
kiwi := New("./ModelGenerator", 1, KIWI_BUILD_DEFAULT)
16+
kiwi := New("./base", 1, KIWI_BUILD_DEFAULT)
1717
res, _ := kiwi.Analyze("아버지가 방에 들어가신다", 1, KIWI_MATCH_ALL)
1818

1919
expected := []TokenResult{
@@ -64,7 +64,7 @@ func TestAnalyze(t *testing.T) {
6464
}
6565

6666
func TestSplitSentence(t *testing.T) {
67-
kiwi := New("./ModelGenerator", 1, KIWI_BUILD_DEFAULT)
67+
kiwi := New("./base", 1, KIWI_BUILD_DEFAULT)
6868
res, _ := kiwi.SplitSentence("여러 문장으로 구성된 텍스트네 이걸 분리해줘", KIWI_MATCH_ALL)
6969

7070
expected := []SplitResult{
@@ -85,14 +85,16 @@ func TestSplitSentence(t *testing.T) {
8585
}
8686

8787
func TestAddWordFail(t *testing.T) {
88-
kb := NewBuilder("./ModelGenerator", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
88+
kb := NewBuilder("./base", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
8989
add := kb.AddWord("아버지가", "SKO", 0)
90-
assert.Equal(t, 0, add)
90+
assert.Equal(t, -1, add)
9191
assert.Equal(t, 0, kb.Close())
92+
93+
KiwiClearError()
9294
}
9395

9496
func TestAddWord(t *testing.T) {
95-
kb := NewBuilder("./ModelGenerator", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
97+
kb := NewBuilder("./base", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
9698
add := kb.AddWord("아버지가", "NNG", 0)
9799

98100
assert.Equal(t, 0, add)
@@ -132,12 +134,12 @@ func TestAddWord(t *testing.T) {
132134
Form: "시",
133135
},
134136
{
135-
Position: 12,
137+
Position: 11,
136138
Tag: "EF",
137139
Form: "ᆫ다",
138140
},
139141
},
140-
Score: -36.959194,
142+
Score: -32.80881,
141143
},
142144
}
143145

@@ -146,7 +148,7 @@ func TestAddWord(t *testing.T) {
146148
}
147149

148150
func TestLoadDict(t *testing.T) {
149-
kb := NewBuilder("./ModelGenerator", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
151+
kb := NewBuilder("./base", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
150152
add := kb.LoadDict("./example/user_dict.tsv")
151153

152154
assert.Equal(t, 1, add)
@@ -191,12 +193,12 @@ func TestLoadDict(t *testing.T) {
191193
Form: "시",
192194
},
193195
{
194-
Position: 12,
196+
Position: 11,
195197
Tag: "EF",
196198
Form: "ᆫ다",
197199
},
198200
},
199-
Score: -36.959194,
201+
Score: -32.80881,
200202
},
201203
}
202204

@@ -205,7 +207,7 @@ func TestLoadDict(t *testing.T) {
205207
}
206208

207209
func TestLoadDict2(t *testing.T) {
208-
kb := NewBuilder("./ModelGenerator", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
210+
kb := NewBuilder("./base", 1, KIWI_BUILD_INTEGRATE_ALLOMORPH)
209211
add := kb.LoadDict("./example/user_dict2.tsv")
210212

211213
assert.Equal(t, 3, add)
@@ -236,7 +238,7 @@ func TestLoadDict2(t *testing.T) {
236238
Form: "들어가신다",
237239
},
238240
},
239-
Score: -13.669565,
241+
Score: -12.538677,
240242
},
241243
}
242244

@@ -245,7 +247,7 @@ func TestLoadDict2(t *testing.T) {
245247
}
246248

247249
func TestExtractWord(t *testing.T) {
248-
kb := NewBuilder("./ModelGenerator", 0, KIWI_BUILD_DEFAULT)
250+
kb := NewBuilder("./base", 1, KIWI_BUILD_DEFAULT)
249251
rs := strings.NewReader(`2008년에는 애국가의 작곡자 안익태가 1930년대에 독일 유학 기간 중 친일 활동을 했다는 사실이 밝혀졌다. 이후 안익태가 나치 독일 하의
250252
베를린에서 만주국 10주년 건국 기념음악회를 지휘하는 동영상까지 발굴되어 관련 학계나 사회에 큰 충격을 주었다. 안익태가 친일 행적을 한 바
251253
있다는 빼도박도 못할 증거가 나왔으니까. 영상물의 '만주환상곡'에는 우리가 현재 알고있는 '한국환상곡'의 두 선율("무궁화 삼천리 나의 사랑아,
@@ -263,17 +265,26 @@ func TestExtractWord(t *testing.T) {
263265
POSScore: -1.92593,
264266
Score: 0,
265267
},
268+
{
269+
Form: "익태",
270+
Freq: 4,
271+
POSScore: -0.23702252,
272+
Score: 0,
273+
},
266274
}, wordInfos)
267275
assert.Equal(t, 0, kb.Close())
268276
}
269277

270278
func TestExtractWordwithFile(t *testing.T) {
271-
kb := NewBuilder("./ModelGenerator", 0, KIWI_BUILD_DEFAULT)
279+
kb := NewBuilder("./base", 1, KIWI_BUILD_DEFAULT) // Use single thread for deterministic results
272280
file, _ := os.Open("./example/test.txt")
273281

274282
wordInfos, _ := kb.ExtractWords(file, 10 /*=minCnt*/, 5 /*=maxWordLen*/, 0.0 /*=minScore*/, -25.0 /*=posThreshold*/)
275283
assert.Equal(t, WordInfo{
276-
Form: "무위원", Freq: 17, POSScore: -1.7342134, Score: 0.69981515,
284+
Form: "무위원",
285+
Freq: 17,
286+
POSScore: -1.7342134,
287+
Score: 0.6998151,
277288
}, wordInfos[0])
278289
assert.Equal(t, 0, kb.Close())
279290
}

scripts/install_kiwi.bash

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ echo "set OS env to ${OS:?}"
2121
echo "installing Kiwi version ${KIWI_VERSION:?}"
2222

2323
wget -O kiwi.tgz "https://github.com/bab2min/Kiwi/releases/download/${KIWI_VERSION}/kiwi_${OS}_${ARCH}_${KIWI_VERSION}.tgz" &&
24-
sudo mkdir -p /usr/local/kiwi &&
25-
sudo tar xzvf kiwi.tgz &&
26-
sudo cp lib/libkiwi* /usr/local/lib &&
27-
sudo cp -rf include/kiwi /usr/local/include &&
24+
sudo tar xzvf kiwi.tgz -C /usr/local &&
2825
[[ "$(uname)" == "Linux" ]] && sudo ldconfig || echo 'skip' &&
29-
rm -rf kiwi.tgz bin lib include
26+
rm -f kiwi.tgz

0 commit comments

Comments
 (0)