Skip to content

Commit e465876

Browse files
authored
feat: new Excel upload form and API (apache#28105)
1 parent 37f900a commit e465876

File tree

31 files changed

+1714
-889
lines changed

31 files changed

+1714
-889
lines changed

RESOURCES/STANDARD_ROLES.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,10 @@ under the License.
6767
| can invalidate on CacheRestApi |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
6868
| can function names on Database |:heavy_check_mark:|O|O|O|
6969
| can csv upload on Database |:heavy_check_mark:|O|O|O|
70+
| can excel upload on Database |:heavy_check_mark:|O|O|O|
7071
| can query form data on Api |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
7172
| can query on Api |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
7273
| can time range on Api |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
73-
| can this form get on ExcelToDatabaseView |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
74-
| can this form post on ExcelToDatabaseView |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
7574
| can external metadata on Datasource |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|
7675
| can save on Datasource |:heavy_check_mark:|:heavy_check_mark:|O|O|
7776
| can get on Datasource |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:|O|

superset-frontend/package-lock.json

Lines changed: 156 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

superset-frontend/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@
204204
"use-event-callback": "^0.1.0",
205205
"use-immer": "^0.9.0",
206206
"use-query-params": "^1.1.9",
207+
"xlsx": "^0.18.5",
207208
"yargs": "^17.7.2"
208209
},
209210
"devDependencies": {

superset-frontend/src/features/databases/CSVUploadModal/ColumnsPreview.tsx renamed to superset-frontend/src/features/databases/UploadDataModel/ColumnsPreview.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const ColumnsPreview: React.FC<ColumnsPreviewProps> = ({
4343
<StyledDivContainer>
4444
<Typography.Text type="secondary">Columns:</Typography.Text>
4545
{columns.length === 0 ? (
46-
<p className="help-block">{t('Upload CSV file to preview columns')}</p>
46+
<p className="help-block">{t('Upload file to preview columns')}</p>
4747
) : (
4848
<TagsList tags={tags} maxTags={maxColumnsToShow} />
4949
)}

0 commit comments

Comments
 (0)