-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Open
Labels
featureNew user visible featureNew user visible feature
Milestone
Description
Hi. Since native sync is available upstream, is there motivation to implement this? maybe choosing a different "backend" (eg github gists, a la settings sync ext
JtMotoX, xfoobar, prokher, csaska, LeonardAB and 35 morejamieweavis and tieb62
Metadata
Metadata
Assignees
Labels
featureNew user visible featureNew user visible feature
Activity
code-asher commentedon Oct 12, 2020
I'd like to get it working but I'm unsure if it's possible. Will need to investigate. Related: #2064
Stradivario commentedon Oct 14, 2020
I can help with this feature also.
code-asher commentedon Oct 14, 2020
csaska commentedon Nov 23, 2020
Settings Sync by Shan Khan seems like a fine alternative for now.
However, it does not appear to work if code-server is used behind a HTTPS reverse proxy. If code-server is running behind a reverse proxy, clicking
Login With GitHub
will generate a bad URI for the callback as this extension is not aware that it is behind a proxy.E.g.
code-server
running onlocalhost:54321
behind a proxy that is exposed viamy.domain.com
. Clicking "Login with GitHub" generates http://localhost:54321/callback?code=1234 instead of https://my.domain.com/callback?code=1234code-asher commentedon Nov 23, 2020
csaska commentedon Nov 23, 2020
Yea definitely a problem with the extension. I just wanted to comment here to link the two issues together.
If the following headers are set by the proxy, and the extension has access to the original request received from code-server, it should be able to generate a valid URI.
E.g.
I am completely naive to how code-server sends requests to VS Code and what the extension has access to.
38 remaining items