Skip to content

Native settings sync #2195

@pwoolvett

Description

@pwoolvett

Hi. Since native sync is available upstream, is there motivation to implement this? maybe choosing a different "backend" (eg github gists, a la settings sync ext

Activity

code-asher

code-asher commented on Oct 12, 2020

@code-asher
Member

I'd like to get it working but I'm unsure if it's possible. Will need to investigate. Related: #2064

Stradivario

Stradivario commented on Oct 14, 2020

@Stradivario

I can help with this feature also.

code-asher

code-asher commented on Oct 14, 2020

@code-asher
Member
csaska

csaska commented on Nov 23, 2020

@csaska
Contributor

Settings Sync by Shan Khan seems like a fine alternative for now.

However, it does not appear to work if code-server is used behind a HTTPS reverse proxy. If code-server is running behind a reverse proxy, clicking Login With GitHub will generate a bad URI for the callback as this extension is not aware that it is behind a proxy.

E.g. code-server running on localhost:54321 behind a proxy that is exposed via my.domain.com. Clicking "Login with GitHub" generates http://localhost:54321/callback?code=1234 instead of https://my.domain.com/callback?code=1234

code-asher

code-asher commented on Nov 23, 2020

@code-asher
Member
csaska

csaska commented on Nov 23, 2020

@csaska
Contributor

Yea definitely a problem with the extension. I just wanted to comment here to link the two issues together.

If the following headers are set by the proxy, and the extension has access to the original request received from code-server, it should be able to generate a valid URI.

E.g.

      proxy_set_header   Host                 $host;
      proxy_set_header   X-Real-IP            $remote_addr;
      proxy_set_header   X-Forwarded-For      $proxy_add_x_forwarded_for;
      proxy_set_header   X-Forwarded-Proto    $scheme;
      proxy_set_header   X-Forwarded-Prefix   /prefix/if/there/is/one;

I am completely naive to how code-server sends requests to VS Code and what the extension has access to.

added
enhancementSome improvement that isn't a feature
featureNew user visible feature
and removed
enhancementSome improvement that isn't a feature
on Dec 7, 2020

38 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew user visible feature

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Native settings sync · Issue #2195 · coder/code-server