Skip to content

Support and publish Windows release #1397

Open
@nhooyr

Description

@nhooyr
  • Should be able to build on Windows
    See linked issues, make sure they work
    Publish Windows releases as part of CI

Activity

danny-laa

danny-laa commented on May 1, 2020

@danny-laa

@nhooyr Any updates? Does 3.0 release support Windows?

nhooyr

nhooyr commented on May 1, 2020

@nhooyr
ContributorAuthor

There are no self contained windows releases yet.

We haven't tested but the npm package might work on windows. yarn global add code-server

max-hk

max-hk commented on May 2, 2020

@max-hk
Contributor

There are no self contained windows releases yet.

We haven't tested but the npm package might work on windows. yarn global add code-server

I was able to install the npm package in windows, but I encounter a few bugs,

  1. src/browser/media/manifest.json not found

  2. All vscode-remote-resource path returns 404 not found, but this bug can easily be solved by removing leading slash in the path agument, eg.

    http://127.0.0.1:8080/vscode-remote-resource?path=/c:/Users/Max/AppData/Local/Yarn/Data/global/node_modules/@coder/code-server/lib/vscode/extensions/markdown-basics/language-configuration.json
    ➡ 404 not found

    http://127.0.0.1:8080/vscode-remote-resource?path=c:/Users/Max/AppData/Local/Yarn/Data/global/node_modules/@coder/code-server/lib/vscode/extensions/markdown-basics/language-configuration.json
    ➡ Correct path

  3. Syntax highlighting, extensions and themes not working (because of 2)

  4. Automatic update not working because https://github.com/cdr/code-server/releases/download/3.2.0/code-server-3.2.0-win32-x86_64.tar.gz does not exist

Furthermore, running the post install scripts requires Visual Studio and "VC++ 2015.3 v140 toolset for desktop (x86,x64)" to be installed, but since running code-server does not require electron to be built, I think it may be unnecessary.

self-assigned this
on May 3, 2020
nhooyr

nhooyr commented on May 3, 2020

@nhooyr
ContributorAuthor

@MaxLOh Awesome thanks for looking into it!

nhooyr

nhooyr commented on May 6, 2020

@nhooyr
ContributorAuthor

The package is now just code-server on npm. We were able to get ownership from the previous owner.

src/browser/media/manifest.json not found

Fixed.

All vscode-remote-resource path returns 404 not found, but this bug can easily be solved by removing leading slash in the path agument, eg.

@code-asher

Automatic update not working because https://github.com/cdr/code-server/releases/download/3.2.0/code-server-3.2.0-win32-x86_64.tar.gz does not exist

We'll be removing automatic updates soon. See #1532 .

Furthermore, running the post install scripts requires Visual Studio and "VC++ 2015.3 v140 toolset for desktop (x86,x64)" to be installed, but since running code-server does not require electron to be built, I think it may be unnecessary.

Will mention this in docs, it is required as vscode uses native modules that have to be built.

added a commit that references this issue on May 12, 2020
nhooyr

nhooyr commented on May 13, 2020

@nhooyr
ContributorAuthor

Asher has fixed the paths, will publish a new release soon.

nhooyr

nhooyr commented on May 13, 2020

@nhooyr
ContributorAuthor

We're going to need to test/rewrite any shell scripts that will have to run on Windows.

nhooyr

nhooyr commented on May 18, 2020

@nhooyr
ContributorAuthor

Marking this for v3.4.0, couldn't test/get CI going in time for v3.3.0

added this to the v3.4.0 milestone on May 18, 2020
modified the milestones: v3.4.0, v3.3.2 on May 27, 2020

91 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciIssues related to cienhancementSome improvement that isn't a featureos-windowsWindows related

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Support and publish Windows release · Issue #1397 · coder/code-server