we don't use found_target_functions

Author: KRRT7

codeflash/discovery/discover_unit_tests.py

@@ -217,15 +217,15 @@ def visit_Attribute(self, node: ast.Attribute) -> None:
         self.generic_visit(node)
 
 
-def analyze_imports_in_test_file(test_file_path: Path | str, target_functions: set[str]) -> tuple[bool, set[str]]:
+def analyze_imports_in_test_file(test_file_path: Path | str, target_functions: set[str]) -> bool:
     """Analyze imports in a test file to determine if it might test any target functions.
 
     Args:
         test_file_path: Path to the test file
         target_functions: Set of function names we're looking for
 
     Returns:
-        Tuple of (should_process_with_jedi, found_function_names)
+        bool: True if the test file should be processed (contains relevant imports), False otherwise
 
     """
     if isinstance(test_file_path, str):
@@ -239,14 +239,11 @@ def analyze_imports_in_test_file(test_file_path: Path | str, target_functions: s
         analyzer = ImportAnalyzer(target_functions)
         analyzer.visit(tree)
 
-        if analyzer.found_target_functions:
-            return True, analyzer.found_target_functions
-
-        return False, set()  # noqa: TRY300
+        return bool(analyzer.found_target_functions)
 
     except (SyntaxError, UnicodeDecodeError, OSError) as e:
         logger.debug(f"Failed to analyze imports in {test_file_path}: {e}")
-        return True, set()
+        return True
 
 
 def filter_test_files_by_imports(
@@ -268,16 +265,15 @@ def filter_test_files_by_imports(
     logger.debug(f"Target functions for import filtering: {target_functions}")
 
     filtered_map = {}
-    num_analyzed = 0
 
     for test_file, test_functions in file_to_test_map.items():
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
-        num_analyzed += 1
-
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
         if should_process:
             filtered_map[test_file] = test_functions
 
-    logger.debug(f"analyzed {num_analyzed} test files for imports, filtered down to {len(filtered_map)} relevant files")
+    logger.debug(
+        f"analyzed {len(file_to_test_map)} test files for imports, filtered down to {len(filtered_map)} relevant files"
+    )
     return filtered_map
 
 

tests/test_unit_test_discovery.py

@@ -811,11 +811,9 @@ def test_target():
         test_file.write_text(test_content)
 
         target_functions = {"target_function", "missing_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
-        assert "missing_function" not in found_functions
 
 
 def test_analyze_imports_star_import():
@@ -831,10 +829,9 @@ def test_something():
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is False
-        assert found_functions == set()
 
 
 def test_analyze_imports_module_import():
@@ -850,10 +847,9 @@ def test_target():
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
 
 
 def test_analyze_imports_dynamic_import():
@@ -870,10 +866,9 @@ def test_dynamic():
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
 
 
 def test_analyze_imports_builtin_import():
@@ -888,10 +883,9 @@ def test_builtin_import():
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
 
 
 def test_analyze_imports_no_matching_imports():
@@ -907,9 +901,8 @@ def test_unrelated():
         test_file.write_text(test_content)
 
         target_functions = {"target_function", "another_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
         assert should_process is False
-        assert found_functions == set()
 
 
 def test_analyze_qualified_names():
@@ -924,9 +917,8 @@ def test_target():
         test_file.write_text(test_content)
 
         target_functions = {"target_module.some_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
         assert should_process is True
-        assert "target_module.some_function" in found_functions
 
 
 
@@ -943,11 +935,10 @@ def test_target(
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         # Should be conservative with unparseable files
         assert should_process is True
-        assert found_functions == set()
 
 
 def test_filter_test_files_by_imports():
@@ -1085,10 +1076,9 @@ def test_conditional():
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
 
 
 def test_analyze_imports_function_name_in_code():
@@ -1108,10 +1098,9 @@ def test_indirect():
         test_file.write_text(test_content)
 
         target_functions = {"target_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
 
 
 def test_analyze_imports_aliased_imports():
@@ -1128,11 +1117,9 @@ def test_aliased():
         test_file.write_text(test_content)
 
         target_functions = {"target_function", "missing_function"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is True
-        assert "target_function" in found_functions
-        assert "missing_function" not in found_functions
 
 
 def test_analyze_imports_underscore_function_names():
@@ -1147,10 +1134,9 @@ def test_bubble():
         test_file.write_text(test_content)
 
         target_functions = {"bubble_sort"}
-        should_process, found_functions = analyze_imports_in_test_file(test_file, target_functions)
+        should_process = analyze_imports_in_test_file(test_file, target_functions)
 
         assert should_process is False
-        assert "bubble_sort" not in found_functions
 
 def test_discover_unit_tests_filtering_different_modules():
     """Test import filtering with test files from completely different modules."""