Buffer out of bounds access through pointer in rapidxml [ASAN]

[stevetranby]

I'm not sure if there's an issue for this, but the check if beyond end of string should be tested before dereferencing the pointer to the buffer.

cocos2d-x-3rd-party-libs-bin/rapidxml/rapidxml.hpp

Line 1424 in 14040db

if (*text == 0 || text >= endptr_)

e.g. (should check if gone past end first, otherwise check if it points to a null terminator \0 character):

//if (*text == 0 || text >= endptr_)
if (text >= endptr_ || *text == 0)
                    break;

[dumganhar]

Yep, I think it should check whether the text pointer is valid first. Otherwise, it will read an invalid byte.