add tests, and style

Author: dsweber2

R/autoplot.R

@@ -32,12 +32,15 @@
 #'   .color_by = "none",
 #'   .facet_by = "geo_value"
 #' )
-#' autoplot(jhu_csse_daily_subset, case_rate_7d_av, .color_by = "none",
-#'   .base_color = "red", .facet_by = "geo_value")
+#' autoplot(jhu_csse_daily_subset, case_rate_7d_av,
+#'   .color_by = "none",
+#'   .base_color = "red", .facet_by = "geo_value"
+#' )
 #'
 #' # .base_color specification won't have any effect due .color_by default
 #' autoplot(jhu_csse_daily_subset, case_rate_7d_av,
-#'   .base_color = "red", .facet_by = "geo_value")
+#'   .base_color = "red", .facet_by = "geo_value"
+#' )
 autoplot.epi_df <- function(
     object, ...,
     .color_by = c("all_keys", "geo_value", "other_keys", ".response", "all", "none"),
@@ -59,7 +62,8 @@ autoplot.epi_df <- function(
   allowed <- allowed[allowed]
   if (length(allowed) == 0 && rlang::dots_n(...) == 0L) {
     cli::cli_abort("No numeric variables were available to plot automatically.",
-      class = "epiprocess__no_numeric_vars_available")
+      class = "epiprocess__no_numeric_vars_available"
+    )
   }
   vars <- tidyselect::eval_select(rlang::expr(c(...)), object)
   if (rlang::is_empty(vars)) { # find them automatically if unspecified
@@ -76,11 +80,13 @@ autoplot.epi_df <- function(
         class = "epiprocess__all_requested_vars_not_numeric"
       )
     } else if (!all(ok)) {
-      cli::cli_warn(c(
-        "Only the requested variables {.var {names(vars)[ok]}} are numeric.",
-        i = "`autoplot()` cannot display {.var {names(vars)[!ok]}}."
-      ),
-      class = "epiprocess__some_requested_vars_not_numeric")
+      cli::cli_warn(
+        c(
+          "Only the requested variables {.var {names(vars)[ok]}} are numeric.",
+          i = "`autoplot()` cannot display {.var {names(vars)[!ok]}}."
+        ),
+        class = "epiprocess__some_requested_vars_not_numeric"
+      )
       vars <- vars[ok]
     }
   }

R/epi_df.R

@@ -297,9 +297,11 @@ as_epi_df.epi_df <- function(x, ...) {
 #' @export
 as_epi_df.tbl_df <- function(x, geo_type, time_type, as_of,
                              additional_metadata = list(), ...) {
-  if (!test_subset(c("geo_value", "time_value"), names(x))) cli_abort(
-    "Columns `geo_value` and `time_value` must be present in `x`."
-  )
+  if (!test_subset(c("geo_value", "time_value"), names(x))) {
+    cli_abort(
+      "Columns `geo_value` and `time_value` must be present in `x`."
+    )
+  }
 
   new_epi_df(
     x, geo_type, time_type, as_of,

R/outliers.R

@@ -109,9 +109,11 @@ detect_outlr <- function(x = seq_along(y), y,
 
     # Validate the output
     assert_data_frame(results)
-    if (!test_subset(c("lower", "upper", "replacement"), colnames(results))) cli_abort(
-      "Columns `lower`, `upper`, and `replacement` must be present in the output of the outlier detection method."
-    )
+    if (!test_subset(c("lower", "upper", "replacement"), colnames(results))) {
+      cli_abort(
+        "Columns `lower`, `upper`, and `replacement` must be present in the output of the outlier detection method."
+      )
+    }
 
     # Update column names with model abbreviation
     colnames(results) <- paste(abbr, colnames(results), sep = "_")

tests/testthat/test-utils.R

@@ -89,6 +89,13 @@ test_that("guess_time_type works for different types", {
   expect_equal(guess_time_type(not_ymd3), "custom")
   expect_equal(guess_time_type(not_a_date), "custom")
 })
+3
+test_that("guess_time_type works with gaps", {
+  days_gaps <- as.Date("2022-01-01") + c(0, 1, 3, 4, 8, 8 + 7)
+  weeks_gaps <- as.Date("2022-01-01") + 7 * c(0, 1, 3, 4, 8, 8 + 7)
+  expect_equal(guess_time_type(days_gaps), "day")
+  expect_equal(guess_time_type(weeks_gaps), "week")
+})
 
 test_that("enlist works", {
   my_list <- enlist(x = 1, y = 2, z = 3)