Adding multi-region functionality issue #2.

Author: Chris Machler

lambda-ebs-backup-cleanup.py

@@ -2,7 +2,8 @@
 import re
 import datetime
 
-ec = boto3.client('ec2')
+regions = ['us-west-2','us-east-2']
+
 iam = boto3.client('iam')
 
 """
@@ -12,29 +13,31 @@
 """
 
 def lambda_handler(event, context):
-    account_ids = list()
-    try:
-        """
-        You can replace this try/except by filling in `account_ids` yourself.
-        Get your account ID with:
-        > import boto3
-        > iam = boto3.client('iam')
-        > print iam.get_user()['User']['Arn'].split(':')[4]
-        """
-        iam.get_user()
-    except Exception as e:
-        # use the exception message to get the account ID the function executes under
-        account_ids.append(re.search(r'(arn:aws:sts::)([0-9]+)', str(e)).groups()[1])
-
-
-    delete_on = datetime.date.today().strftime('%Y-%m-%d')
-    filters = [
-        {'Name': 'tag-key', 'Values': ['DeleteOn']},
-        {'Name': 'tag-value', 'Values': [delete_on]},
-    ]
-    snapshot_response = ec.describe_snapshots(OwnerIds=account_ids, Filters=filters)
-
-
-    for snap in snapshot_response['Snapshots']:
-        print "Deleting snapshot %s" % snap['SnapshotId']
-        ec.delete_snapshot(SnapshotId=snap['SnapshotId'])
+    for region in regions:
+        ec = boto3.client('ec2', region_name=region)
+        account_ids = list()
+        try:
+            """
+            You can replace this try/except by filling in `account_ids` yourself.
+            Get your account ID with:
+            > import boto3
+            > iam = boto3.client('iam')
+            > print iam.get_user()['User']['Arn'].split(':')[4]
+            """
+            iam.get_user()
+        except Exception as e:
+            # use the exception message to get the account ID the function executes under
+            account_ids.append(re.search(r'(arn:aws:sts::)([0-9]+)', str(e)).groups()[1])
+
+
+        delete_on = datetime.date.today().strftime('%Y-%m-%d')
+        filters = [
+            {'Name': 'tag-key', 'Values': ['DeleteOn']},
+            {'Name': 'tag-value', 'Values': [delete_on]},
+        ]
+        snapshot_response = ec.describe_snapshots(OwnerIds=account_ids, Filters=filters)
+
+
+        for snap in snapshot_response['Snapshots']:
+            print "Deleting snapshot %s" % snap['SnapshotId']
+            ec.delete_snapshot(SnapshotId=snap['SnapshotId'])

lambda-ebs-backup.py

@@ -2,74 +2,76 @@
 import collections
 import datetime
 
-ec = boto3.client('ec2')
+regions = ['us-west-2','us-east-2']
 
 def lambda_handler(event, context):
-    reservations = ec.describe_instances(
-        Filters=[
-            {'Name': 'tag-key', 'Values': ['backup', 'Backup']},
-        ]
-    ).get(
-        'Reservations', []
-    )
+    for region in regions:
+        ec = boto3.client('ec2', region_name=region)
+        reservations = ec.describe_instances(
+            Filters=[
+                {'Name': 'tag-key', 'Values': ['backup', 'Backup']},
+            ]
+        ).get(
+            'Reservations', []
+        )
 
-    instances = sum(
-        [
-            [i for i in r['Instances']]
-            for r in reservations
-        ], [])
+        instances = sum(
+            [
+                [i for i in r['Instances']]
+                for r in reservations
+            ], [])
 
-    print "Found %d instances that need backing up" % len(instances)
+        print "Found %d instances that need backing up" % len(instances)
 
-    to_tag_retention = collections.defaultdict(list)
-    to_tag_mount_point = collections.defaultdict(list)
+        to_tag_retention = collections.defaultdict(list)
+        to_tag_mount_point = collections.defaultdict(list)
 
-    for instance in instances:
-        try:
-            retention_days = [
-                int(t.get('Value')) for t in instance['Tags']
-                if t['Key'] == 'Retention'][0]
-        except IndexError:
-            retention_days = 7
+        for instance in instances:
+            try:
+                retention_days = [
+                    int(t.get('Value')) for t in instance['Tags']
+                    if t['Key'] == 'Retention'][0]
+            except IndexError:
+                retention_days = 7
 
-        for dev in instance['BlockDeviceMappings']:
-            if dev.get('Ebs', None) is None:
-                continue
-            vol_id = dev['Ebs']['VolumeId']
-            dev_attachment = dev['DeviceName']
-            print "Found EBS volume %s on instance %s attached to %s" % (
-                vol_id, instance['InstanceId'], dev_attachment)
+            for dev in instance['BlockDeviceMappings']:
+                if dev.get('Ebs', None) is None:
+                    continue
+                vol_id = dev['Ebs']['VolumeId']
+                dev_attachment = dev['DeviceName']
+                print "Found EBS volume %s on instance %s attached to %s" % (
+                    vol_id, instance['InstanceId'], dev_attachment)
 
-            snap = ec.create_snapshot(
-                VolumeId=vol_id,
-                Description=instance['InstanceId'],
-            )
+                snap = ec.create_snapshot(
+                    VolumeId=vol_id,
+                    Description=instance['InstanceId'],
+                )
 
-            to_tag_retention[retention_days].append(snap['SnapshotId'])
-            to_tag_mount_point[vol_id].append(snap['SnapshotId'])
+                to_tag_retention[retention_days].append(snap['SnapshotId'])
+                to_tag_mount_point[vol_id].append(snap['SnapshotId'])
 
 
-            print "Retaining snapshot %s of volume %s from instance %s for %d days" % (
-                snap['SnapshotId'],
-                vol_id,
-                instance['InstanceId'],
-                retention_days,
-            )
+                print "Retaining snapshot %s of volume %s from instance %s for %d days" % (
+                    snap['SnapshotId'],
+                    vol_id,
+                    instance['InstanceId'],
+                    retention_days,
+                )
 
+                ec.create_tags(
+                    Resources=to_tag_mount_point[vol_id],
+                    Tags=[
+                        {'Key': 'Name', 'Value': dev_attachment},
+                    ]
+                )
+
+        for retention_days in to_tag_retention.keys():
+            delete_date = datetime.date.today() + datetime.timedelta(days=retention_days)
+            delete_fmt = delete_date.strftime('%Y-%m-%d')
+            print "Will delete %d snapshots on %s" % (len(to_tag_retention[retention_days]), delete_fmt)
             ec.create_tags(
-                Resources=to_tag_mount_point[vol_id],
+                Resources=to_tag_retention[retention_days],
                 Tags=[
-                    {'Key': 'Name', 'Value': dev_attachment},
+                    {'Key': 'DeleteOn', 'Value': delete_fmt},
                 ]
             )
-
-    for retention_days in to_tag_retention.keys():
-        delete_date = datetime.date.today() + datetime.timedelta(days=retention_days)
-        delete_fmt = delete_date.strftime('%Y-%m-%d')
-        print "Will delete %d snapshots on %s" % (len(to_tag_retention[retention_days]), delete_fmt)
-        ec.create_tags(
-            Resources=to_tag_retention[retention_days],
-            Tags=[
-                {'Key': 'DeleteOn', 'Value': delete_fmt},
-            ]
-        )