Deref when transacting schema, skip non-message reactions

When transacting the schema upon startup, deref the tx-data so that exceptions
will bubble. This should also means deploys roll back when the schema fails to
transact.

Skip reaction messages unless we get a channel and message id, because we can
have reactions on non-message items (i.e. files).

Author: plexus

repl/emoji_cleanup.clj

@@ -0,0 +1,35 @@
+(ns emoji-cleanup
+  (:require [clojurians-log.datomic :as d]
+            [clojurians-log.repl :as repl]
+            [clojurians-log.slack-api :as slack]))
+
+;; Our :emoji/shortcode property did not originally have an index, meaning we
+;; kept creating more entities for emojis, instead of upserting them.
+;;
+;; To fix this, first retract all shortcode attributes, then transact the schema
+;; so it gets the index, then re-import
+
+;; Do the following before deploying the new schema changes:
+
+(def shortcodes (d/q '[:find ?i ?s :where [?i :emoji/shortcode ?s]] (repl/db)))
+(def tx-data (for [[i s] shortcodes]
+               [:db/retract i :emoji/shortcode s]))
+
+(run! (partial d/transact (repl/conn)) (partition-all 1000 tx-data))
+
+@(d/transact (repl/conn) [{:db/ident       :emoji/shortcode
+                           :db/valueType   :db.type/string
+                           :db/cardinality :db.cardinality/one
+                           :db/unique      :db.unique/identity}])
+
+(slack/import-emojis! (repl/conn))
+
+;; After deploying the new version, re-import the data to get the emoji reactions in there
+
+(def result (load-files! (log-files))) ;; [(volatile count) (promise)]
+
+(future
+  (while (not (realized? (second result)))
+    (println @(first result))
+    (Thread/sleep 2000))
+  (println :done))

src/clojurians_log/components/datomic_schema.clj

@@ -6,10 +6,10 @@
 (defrecord DatomicSchema [datomic]
   component/Lifecycle
   (start [this]
-    (d/transact (:conn datomic)
-                (if d/cloud?
-                  (map #(dissoc % :db/index) schema/full-schema)
-                  schema/full-schema)))
+    @(d/transact (:conn datomic)
+                 (if d/cloud?
+                   (map #(dissoc % :db/index) schema/full-schema)
+                   schema/full-schema)))
   (stop [this]))
 
 (defn new-datomic-schema []

src/clojurians_log/db/import.clj

@@ -94,12 +94,16 @@
   #:emoji {:shortcode (name shortcode)
            :url       url})
 
-(defmethod event->tx ["reaction_added" nil] [{:keys [user item reaction item_user event_ts ts]}]
-  {:reaction/type "reaction_added"
-   :reaction/emoji {:emoji/shortcode reaction}
-   :reaction/ts ts
-   :reaction/user [:user/slack-id user]
-   :reaction/message {:message/key (message-key item)}})
+;; TODO: deal with reactions on files (I guess this will depend on us actually dealing with files in the first place :))
+;; {:reaction "joy", :event_ts "1521818444.000850", :item {:type "file", :file "F9W0B0LHM"}, :user "U06P56UUB", :item_user "U4E5W80P7", :type "reaction_added"}
+
+(defmethod event->tx ["reaction_added" nil] [{:keys [user item reaction item_user event_ts ts] :as msg}]
+  (when (and (:channel item) (:ts item)) ; exclude reactions on things other than messages
+    {:reaction/type "reaction_added"
+     :reaction/emoji {:emoji/shortcode reaction}
+     :reaction/ts ts
+     :reaction/user [:user/slack-id user]
+     :reaction/message {:message/key (message-key item)}}))
 
 (defmethod event->tx ["reaction_removed" nil] [{:keys [user item reaction item_user event_ts ts]}]
   ;; Placeholder just to show that we're getting some data.