Check in code to clean up reactions

Author: plexus

repl/emoji_cleanup.clj

@@ -1,8 +1,19 @@
 (ns repl.emoji-cleanup
   (:require [clojurians-log.datomic :as d]
+            [clojurians-log.application :as app]
             [clojurians-log.repl :as repl]
             [clojurians-log.slack-api :as slack]))
 
+(defn conn
+  "Reach into the system for the datomic connection.
+
+  Not 100% kosher but remember this is not production code as such."
+  []
+  (get-in (app/system) [:datomic :conn]))
+
+(defn db []
+  (d/db (conn)))
+
 ;; Our :emoji/shortcode property did not originally have an index, meaning we
 ;; kept creating more entities for emojis, instead of upserting them.
 ;;
@@ -11,18 +22,18 @@
 
 ;; Do the following before deploying the new schema changes:
 
-(def shortcodes (d/q '[:find ?i ?s :where [?i :emoji/shortcode ?s]] (repl/db)))
+(def shortcodes (d/q '[:find ?i ?s :where [?i :emoji/shortcode ?s]] (db)))
 (def tx-data (for [[i s] shortcodes]
                [:db/retract i :emoji/shortcode s]))
 
-(run! (partial d/transact (repl/conn)) (partition-all 1000 tx-data))
+(run! (partial d/transact (conn)) (partition-all 1000 tx-data))
 
-@(d/transact (repl/conn) [{:db/ident       :emoji/shortcode
-                           :db/valueType   :db.type/string
-                           :db/cardinality :db.cardinality/one
-                           :db/unique      :db.unique/identity}])
+@(d/transact (conn) [{:db/ident       :emoji/shortcode
+                      :db/valueType   :db.type/string
+                      :db/cardinality :db.cardinality/one
+                      :db/unique      :db.unique/identity}])
 
-(slack/import-emojis! (repl/conn))
+(slack/import-emojis! (conn))
 
 ;; After deploying the new version, re-import the data to get the emoji reactions in there
 
@@ -34,9 +45,23 @@
     (Thread/sleep 2000))
   (println :done))
 
+;; Check vincent's message, should have +4 -1 hearts (= 3 hearts)
+
 (group-by second
           (map (juxt :reaction/type
                      (comp :emoji/shortcode :reaction/emoji))
                (:reaction/_message
-                (datomic.api/entity (repl/db)
+                (datomic.api/entity (db)
                                     [:message/key "C0GLTDB2T--1608789973.125700"]))))
+
+
+;; Re-do reactions but now including the key
+
+
+(def reactions (d/q '[:find [?r ?m]  :where [?r :reaction/message ?m]] (db)))
+(def tx-data (for [[r m] reactions]
+               [:db/retract r :reaction/message ?m]))
+
+(run! (partial d/transact (conn)) (partition-all 1000 tx-data))
+
+(count (d/q '[:find [?r ?m]  :where [?r :reaction/message ?m]] (db)))

src/clojurians_log/db/import.clj

@@ -97,11 +97,13 @@
 ;; TODO: deal with reactions on files (I guess this will depend on us actually dealing with files in the first place :))
 ;; {:reaction "joy", :event_ts "1521818444.000850", :item {:type "file", :file "F9W0B0LHM"}, :user "U06P56UUB", :item_user "U4E5W80P7", :type "reaction_added"}
 
-(defn- reaction-entity [{:keys [user item reaction ts]}]
-  {:reaction/emoji {:emoji/shortcode reaction}
-   :reaction/ts ts
-   :reaction/user [:user/slack-id user]
-   :reaction/message {:message/key (message-key item)}})
+(defn- reaction-entity [{:keys [user item reaction ts type]}]
+  (let [msg-key (message-key item)]
+    {:reaction/emoji {:emoji/shortcode reaction}
+     :reaction/ts ts
+     :reaction/user [:user/slack-id user]
+     :reaction/message {:message/key msg-key}
+     :reaction/key (str message-key "--" user "--" ts "--" reaction "--" type)}))
 
 (defmethod event->tx ["reaction_added" nil] [{:keys [item] :as msg}]
   (when (and (:channel item) (:ts item)) ; exclude reactions on things other than messages

src/clojurians_log/db/schema.clj

@@ -161,7 +161,12 @@
     :db/cardinality :db.cardinality/one}
    {:db/ident       :reaction/message
     :db/valueType   :db.type/ref
-    :db/cardinality :db.cardinality/one}])
+    :db/cardinality :db.cardinality/one}
+   {:db/ident       :reaction/key
+    :db/doc         "Unique key for a given reaction event, so inserts are idempotent."
+    :db/valueType   :db.type/string
+    :db/cardinality :db.cardinality/one
+    :db/unique      :db.unique/identity}])
 
 (def full-schema
   (concat message-schema