rationalize core.tools/reader

Author: pnf

README.md

@@ -202,7 +202,10 @@ now manifest in emacs.
 
 If something mysterious is happening, you may find it helpful to look at the
 `*nrepl-messages...` buffers, where CIDER silently logs all traffic between EMACS
-and Clojure.  Among other things, you'll find here the Clojure expressions that
+and Clojure.  Note, per the [cider docs](https://cider.readthedocs.io/en/latest/troubleshooting/)
+that you must have such logging turned on, either by setting `nrepl-log-messages` to true or running
+`nrepl-toggle-message-logging`.
+Among other things, you'll find here the Clojure expressions that
 were evaluated to initiate the checking, e.g.
 
 ~~~

elisp/flycheck-clojure/flycheck-clojure.el

@@ -200,7 +200,9 @@ If injecting the dependencies is not preferred set `flycheck-clojure-inject-depe
   (when (and flycheck-clojure-inject-dependencies-at-jack-in
              (boundp 'cider-jack-in-dependencies))
     (cider-add-to-alist 'cider-jack-in-dependencies "acyclic/squiggly-clojure" flycheck-clojure-dep-version)
-    (cider-add-to-alist 'cider-jack-in-dependencies-exclusions "acyclic/squiggly-clojure" '("org.clojure/tools.reader"))))
+    ;; reader is needed by kibit and no longer provided via cider
+    ;;(cider-add-to-alist 'cider-jack-in-dependencies-exclusions "acyclic/squiggly-clojure" '("org.clojure/tools.reader"))
+    ))
 
 ;;;###autoload
 (defun flycheck-clojure-setup ()

project.clj

@@ -5,6 +5,7 @@
             :url "http://www.eclipse.org/legal/epl-v10.html"}
   :dependencies [[org.clojure/clojure "1.9.0"]
                  [environ "1.1.0"]
+                 [org.clojure/tools.reader "1.3.2"]
                  [org.clojure/core.typed "0.5.3" :exclusions [org.clojure/clojure] :classifier "slim"]
                  [org.clojure/data.json "0.2.6"]
                  [jonase/eastwood "0.2.8" :exclusions [org.clojure/clojure]]

sample-project/project.clj

@@ -4,13 +4,18 @@
   :license {:name "Eclipse Public License"
             :url "http://www.eclipse.org/legal/epl-v10.html"}
   :dependencies [[org.clojure/clojure "1.9.0"]
-                 [org.clojure/core.typed "0.5.3"  :classifier "slim"]]
+                 ;; Uncomment to enable core.typed annotations
+                 [org.clojure/core.typed "0.5.3"  :classifier "slim"]
+                 ]
 
   ;; Use lein-environ plugin if you want to set checker configuration in profile.
   :plugins [[lein-environ "1.1.0"]]
 
   ;; Configuration here may be overridden by namespace metadata.
-  :profiles {:dev {:env {:squiggly {:checkers [:eastwood :typed]
+  :profiles {:dev {:env {:squiggly {:checkers [:eastwood
+                                               ;; Uncomment to include type-checking
+                                               ;; :typed
+                                               ]
                                     :eastwood-exclude-linters [:unlimited-use]
                                     :eastwood-options {;; :builtin-config-files ["myconfigfile.clj"]
 

sample-project/src/sample_project/core.clj

@@ -1,9 +1,12 @@
 (ns sample-project.core
-  {:squiggly {:checkers [:kibit :eastwood :typed]
+  {:squiggly {:checkers [:kibit :eastwood
+                         ;; Uncomment to include type checking
+                         ;; :typed  
+                         ]
               :eastwood-exclude-linters [:unlimited-use]
               :eastwood-options {:not-a-real-option "foo"}}
    :lang :core.typed}
-  (:require [clojure.core.typed :as t])
+;  (:require [clojure.core.typed :as t])
 ;;  (:use [clojure.stacktrace])  ;; warning suppressed by :eastwood-exclude-linters
   )