Print more stacktraces in CI

Sometimes stacktraces can be swallowed.

That can be fine, but it is cautious to log all stacktraces in CI.

That can help debugging heisenbugs etc.

Author: vemv

project.clj

@@ -74,4 +74,7 @@
                                    :exclude-linters [:implicit-dependencies]}}
              :clj-kondo [:test
                          {:dependencies [[clj-kondo "2021.06.18"]]}]}
-  :jvm-opts ["-Djava.net.preferIPv4Stack=true"])
+
+  :jvm-opts ~(cond-> ["-Djava.net.preferIPv4Stack=true"]
+               (System/getenv "CI")
+               (conj "-Drefactor-nrepl.internal.log-exceptions=true")))

src/refactor_nrepl/analyzer.clj

@@ -91,7 +91,12 @@
     (when ns
       (if-let [cached-ast-or-err (get-ast-from-cache ns file-content)]
         cached-ast-or-err
-        (when-let [new-ast-or-err (try (build-ast ns aliases) (catch Throwable th th))]
+        (when-let [new-ast-or-err (try
+                                    (build-ast ns aliases)
+                                    (catch Throwable th
+                                      (when (System/getProperty "refactor-nrepl.internal.log-exceptions")
+                                        (-> th .printStackTrace))
+                                      th))]
           (update-ast-cache file-content ns new-ast-or-err))))))
 
 (defn- throw-ast-in-bad-state
@@ -131,7 +136,11 @@
   (doseq [f (tracker/project-files-in-topo-order)]
     (try
       (ns-ast (slurp f))
-      (catch Throwable _th))) ;noop, ast-status will be reported separately
+      (catch Throwable th
+        (when (System/getProperty "refactor-nrepl.internal.log-exceptions")
+          (-> th .printStackTrace))
+        nil ; noop, ast-status will be reported separately
+        )))
   (ast-stats))
 
 (defn node-at-loc? [^long loc-line ^long loc-column node]

src/refactor_nrepl/find/find_macros.clj

@@ -85,6 +85,8 @@
        (mapcat #(try
                   (get-macro-definitions-in-file-with-caching %)
                   (catch Exception e
+                    (when (System/getProperty "refactor-nrepl.internal.log-exceptions")
+                      (-> e .printStackTrace))
                     (when-not ignore-errors?
                       (throw e)))))))
 

src/refactor_nrepl/find/find_symbol.clj

@@ -109,6 +109,8 @@
                        (find-symbol-in-ast fully-qualified-name)
                        (filter :line-beg))
                   (catch Exception e
+                    (when (System/getProperty "refactor-nrepl.internal.log-exceptions")
+                      (-> e .printStackTrace))
                     (when-not ignore-errors
                       (throw e))))
         locs (into

test/refactor_nrepl/integration_tests.clj

@@ -52,7 +52,7 @@
 
 (defn ns-ast-throw-error-for-five [^String content]
   (if (.contains content "com.example.five")
-    (throw (IllegalThreadStateException. "FAILED!"))
+    (throw (IllegalThreadStateException. "Expected!"))
     (#'analyzer/cachable-ast content)))
 
 (deftest test-find-two-foo-errors-ignored