Skip to content

Update the ts grammar #77

Closed
Closed
@bbatsov

Description

@bbatsov

We're using version 0.0.12, but I've noticed there's also 0.0.13 now (https://github.com/sogaiu/tree-sitter-clojure/releases/tag/v0.0.13). @rrudakov Perhaps you wouldn't mind testing how things work with it?

Activity

bbatsov

bbatsov commented on Apr 10, 2025

@bbatsov
MemberAuthor

I'm guessing updating https://github.com/tree-sitter-grammars/tree-sitter-markdown/releases/tag/v0.4.1 might help with #60 - I see the version we're using is ancient at this point.

rrudakov

rrudakov commented on Apr 10, 2025

@rrudakov
Contributor

I'll test it. From the changelog it looks like there were no any API changes.

rrudakov

rrudakov commented on Apr 10, 2025

@rrudakov
Contributor

I'm guessing updating https://github.com/tree-sitter-grammars/tree-sitter-markdown/releases/tag/v0.4.1 might help with #60 - I see the version we're using is ancient at this point.

Will try it too.

My current guess is that range might be calculated incorrectly when you type in a single backtick in the docstring (because in this case the rest of the buffer is highlighted as a docstring), but I planned to investigate it in more details. Updating grammar is not a bad idea either.

rrudakov

rrudakov commented on Apr 10, 2025

@rrudakov
Contributor

Note: our clojure-ts--ensure-grammars won't upgrade grammars if they were already installed (even if version is old). Maybe it would be a good idea to add clojure-ts-upgrade-grammars or something like that.

bbatsov

bbatsov commented on Apr 10, 2025

@bbatsov
MemberAuthor

Yeah, that's a good idea.

added a commit that references this issue on Apr 10, 2025

[clojure-emacs#77] Update grammars

7dacca0
added 2 commits that reference this issue on Apr 10, 2025

[clojure-emacs#77] Update grammars

5110cf5

[clojure-emacs#77] Update grammars

32fd205
added a commit that references this issue on Apr 11, 2025

[#77] Update grammars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementEnhancement to existing functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Update the ts grammar · Issue #77 · clojure-emacs/clojure-ts-mode