Don't exclude enumerable properties from Object (#46)

Fixes #45

Author: vemv

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## master
 
+* [#45](https://github.com/clojure-emacs/clj-suitable/issues/45): don't exclude enumerable properties from `Object`.
+
 ## 0.6.1 (2023-11-07)
 
 - [#44](https://github.com/clojure-emacs/clj-suitable/pull/44): More robust completion for referred keywords. If a given namespace is

Makefile

@@ -13,7 +13,7 @@ clean:
 	lein with-profile -user clean
 
 test: clean
-	clojure -A:test:$(VERSION) -d src/test
+	clojure -M:test:test-runner:$(VERSION)
 
 kondo:
 	clojure -M:dev-figwheel:fig-repl:dev-shadow:test:kondo

deps.edn

@@ -44,14 +44,14 @@
                         :main-opts   ["-m" "figwheel.main" "-b" "fig"]
                         :extra-deps  {com.bhauman/figwheel-main {:mvn/version "0.2.18"}}}
 
-           ;; tests
            :test {:extra-paths ["src/test" "resources"]
-                  :extra-deps  {com.cognitect/test-runner {:git/url "https://github.com/cognitect-labs/test-runner.git"
-                                                           :sha     "209b64504cb3bd3b99ecfec7937b358a879f55c1"}
-                                cider/cider-nrepl         {:mvn/version "0.32.0"}
+                  :extra-deps  {cider/cider-nrepl         {:mvn/version "0.32.0"}
                                 cider/piggieback          {:mvn/version "0.5.3"}}
-                  :jvm-opts    ["-Dclojure.main.report=stderr"]
-                  :main-opts   ["-m" "cognitect.test-runner" "-d" "src/test"]}
+                  :jvm-opts    ["-Dclojure.main.report=stderr"]}
+
+           :test-runner {:extra-deps {com.cognitect/test-runner {:git/url "https://github.com/cognitect-labs/test-runner.git"
+                                                                 :sha     "209b64504cb3bd3b99ecfec7937b358a879f55c1"}}
+                         :main-opts  ["-m" "cognitect.test-runner" "-d" "src/test"]}
 
            ;; build a jar, https://juxt.pro/blog/posts/pack-maven.html
            :pack {:extra-deps {pack/pack.alpha {:git/url "https://github.com/juxt/pack.alpha.git"

src/main/suitable/js_introspection.cljs

@@ -28,7 +28,10 @@
      (for [[i {:keys [_obj props]}] (map-indexed vector (properties-by-prototype js-obj))
            key (js-keys props)
            :when (and (not (get @seen key))
-                      (not (oget (oget props key) "enumerable"))
+                      (if (or (= "[object String]" (js/Object.prototype.toString.call js-obj))
+                              (js/Array.isArray js-obj))
+                        (not (oget (oget props key) "enumerable"))
+                        true)
                       (or (empty? prefix)
                           (starts-with? key prefix)))]
        (let [prop (oget props key)]

src/test/suitable/complete_for_nrepl_test.clj

@@ -105,7 +105,7 @@
         (is (= [{:ns "js/Object", :candidate ".keys" :type "function"}] candidates)
             (pr-str response))))
 
-    (testing "make sure that enumerable items are filtered out"
+    (testing "enumerable items are filtered out"
       (are [context candidates] (= candidates
                                    (let [response   (message {:op      "complete"
                                                               :ns      "cljs.user"
@@ -116,7 +116,19 @@
         [{:candidate ".-length", :ns "(js/String \"abc\")", :type "var"}]
 
         "(-> (js/String \"abc\") __prefix__)"
-        [{:candidate ".-length", :ns "(-> (js/String \"abc\"))", :type "var"}]))))
+        [{:candidate ".-length", :ns "(-> (js/String \"abc\"))", :type "var"}]
+
+        "(__prefix__ #js [1 2 3])"
+        []
+
+        "(__prefix__ (array 1 2 3))"
+        [{:candidate ".-length", :ns "(array 1 2 3)", :type "var"}]
+
+        "(__prefix__ (js/Array. 1 2 3))"
+        [{:candidate ".-length", :ns "(js/Array. 1 2 3)", :type "var"}]
+
+        "(__prefix__ (js/Set. (js/Array. 1 2 3)))"
+        [{:candidate ".-size", :ns "(js/Set. (js/Array. 1 2 3))", :type "var"}]))))
 
 (deftest node-env?
   (is (false? (sut/node-env? nil)))