Skip to content

Commit 41c7e93

Browse files
authored
docs: turf detailed API diff reports (#293)
I generated these when merging rewrite-clj v0 & rewrite-cljs into rewrite-clj v1. They were very useful to me, not sure how much so to others. I used some adoc syntax that happened to work and now longer renders correctly. And the scripts I used to generate these reports no longer work. And, for me, they have served their purpose. And I'd rather spend my time on other things. So, I'm turfing them for now. Closes #132
1 parent 68136de commit 41c7e93

12 files changed

+4
-14342
lines changed

CHANGELOG.adoc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ A release with known breaking changes is marked with:
3434
{issue}279[#279] ({lread})
3535
* `rewrite-clj.paredit/barf-forward` on zipper created with `:track-position? true` now correctly barfs when current node has children
3636
{issue}245[#245] ({lread}, thanks for the issue {person}p4ulcristian[@p4ulcristian]!)
37+
* docs
38+
** Turf API diff reports for now
39+
{issue}132[#132] ({lread})
3740

3841
=== v1.1.47 - 2023-03-25 [[v1.1.47]]
3942

bb.edn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
test-doc {:task test-doc/-main :doc "test doc code blocks"}
3333
test-libs {:task test-libs/-main :doc "(list|run|outdated) - verify that libs using rewrite-clj* work with current rewrite-clj"}
3434
outdated {:task outdated/-main :doc "report on outdated Clojure and npm dependencies"}
35-
doc-api-diffs {:task doc-api-diffs/-main :doc "generate diff docs for rewrite-clj* APIs"}
3635
doc-update-readme {:task doc-update-readme/-main :doc "honour our contributors in README"}
3736
cljdoc-preview {:task cljdoc-preview/-main :doc "preview what docs will look like on cljdoc, use --help for args"}
3837
ci-unit-tests {:task ci-unit-tests/-main :doc "run/list continuous integration unit tests, use --help for args"}

deps.edn

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,6 @@
125125
;; usage -M:sci-test:gen-reflection
126126
:gen-reflection {:main-opts ["-m" "sci-test.generate-reflection-file"]}
127127

128-
;;
129-
;; Document rewrite-clj* differences (needs love!)
130-
;;
131-
:diff-apis {:extra-paths ["script/resources"]
132-
:extra-deps {lread/diff-apis {:git/url "https://github.com/lread/diff-apis"
133-
:sha "cd8096e0b5e0c0ea4850cb9eafe2d085d8912442"}}
134-
:main-opts ["-m" "diff-apis.main" "projects"]}
135-
136128
;;
137129
;; Deployment
138130
;;

doc/02-developer-guide.adoc

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -323,29 +323,6 @@ You can optionally:
323323
* `bb -lint-kondo` to run only clj-kondo linting
324324
* `bb -lint-eastwood` to run only the eastwood linting
325325

326-
== API diffs
327-
Rewrite-clj v1's primary goals include remaining compatible with rewrite-clj v0 and rewrite-cljs and avoiding breaking changes.
328-
329-
To generate reports on differences between rewrite-clj v0, rewrite-cljs and
330-
rewrite-clj v1 APIs, run:
331-
332-
----
333-
bb doc-api-diffs
334-
----
335-
336-
WARNING: This task currently needs love, see https://github.com/clj-commons/rewrite-clj/issues/132[#132].
337-
338-
Run this script manually on an as-needed basis, and certainly before any official release.
339-
Generated reports are to be checked in to version control.
340-
341-
Reports are generated to `doc/generated/api-diffs/` and include manually written notes from `doc/diff-notes/`.
342-
343-
These reports are referenced from other docs, so if you rename files, be sure to search for links.
344-
345-
Makes use of https://github.com/lread/diff-apis[diff-apis].
346-
Delete `.diff-apis/.cache` if you need a clean run.
347-
348-
349326
== Cljdoc Preview
350327
Before a release, it can be comforting to preview what docs will look like on https://cljdoc.org/[cljdoc].
351328

doc/cljdoc.edn

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,7 @@
55
["Developer Guide" {:file "doc/02-developer-guide.adoc"}]
66
["Design" {}
77
["Merging rewrite-clj and rewrite-cljs" {:file "doc/design/01-merging-rewrite-clj-and-rewrite-cljs.adoc"}
8-
["Namespaced Elements" {:file "doc/design/namespaced-elements.adoc"}]]
9-
["API Differences" {}
10-
["rwt-clj v0 vs rwt-cljs" {:file "doc/generated/api-diffs/rewrite-clj-v0-lang-clj-and-rewrite-cljs-lang-cljs.adoc"}]
11-
["rwt-clj v0 vs rwt-clj v1" {:file "doc/generated/api-diffs/rewrite-clj-v0-lang-clj-and-rewrite-clj-v1-lang-clj.adoc"}]
12-
["rwt-cljs vs rwt-clj v1" {:file "doc/generated/api-diffs/rewrite-cljs-lang-cljs-and-rewrite-clj-v1-lang-cljs.adoc"}]
13-
["rwt-clj v1 clj vs cljs all" {:file "doc/generated/api-diffs/rewrite-clj-v1-lang-cljs-and-rewrite-clj-v1-lang-clj.adoc"}]
14-
["rwt-clj v1 clj vs cljs public" {:file "doc/generated/api-diffs/rewrite-clj-v1-lang-cljs-and-rewrite-clj-v1-lang-clj-documented-only.adoc"}]]]
8+
["Namespaced Elements" {:file "doc/design/namespaced-elements.adoc"}]]]
159
["Frequently Asked Questions" {:file "doc/03-faq.adoc"}]
1610
["Contributing" {:file "CONTRIBUTING.md"}]
1711
["Code of Conduct" {:file "CODE_OF_CONDUCT.md"}]

doc/design/01-merging-rewrite-clj-and-rewrite-cljs.adoc

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,6 @@ We will, though, carry over rewrite-cljs's higher level positional functions.
4747
== Changes
4848
See link:../../CHANGELOG.adoc[change log].
4949

50-
=== Detailed API diffs
51-
52-
I've used https://github.com/lread/diff-apis[diff-apis] to compare apis.
53-
Normally I would have excluded any apis tagged with `:no-doc` metadata, but because many folks used undocumented features in rewrite-clj v0 and rewrite-cljs, I have done a complete comparison of all publics - except where noted.
54-
Each report contains some observations under the "Notes" header.
55-
56-
* link:../generated/api-diffs/rewrite-clj-v0-lang-clj-and-rewrite-cljs-lang-cljs.adoc[rewrite-clj v0 vs rewrite-cljs] API differences between the projects on which rewrite-clj v1 is based.
57-
* link:../generated/api-diffs/rewrite-clj-v0-lang-clj-and-rewrite-clj-v1-lang-clj.adoc[rewrite-clj v0 vs rewrite-clj v1] how different is rewrite-clj v1 from rewrite-clj v0?
58-
* link:../generated/api-diffs/rewrite-cljs-lang-cljs-and-rewrite-clj-v1-lang-cljs.adoc[rewrite-cljs vs rewrite-clj v1] how different is rewrite-clj v1 from rewrite-cljs?
59-
* link:../generated/api-diffs/rewrite-clj-v1-lang-cljs-and-rewrite-clj-v1-lang-clj.adoc[rewrite-clj v1] a look at how cljs and clj sides of rewrite-clj v1 differ
60-
* link:../generated/api-diffs/rewrite-clj-v1-lang-cljs-and-rewrite-clj-v1-lang-clj-documented-only.adoc[rewrite-clj v1 documented apis only] a look at how cljs and clj sides of rewrite-clj v1 differ for documented apis.
61-
6250
=== Feature Differences
6351
No ability to read from files when using rewrite-clj v1 from ClojureScript.
6452

0 commit comments

Comments
 (0)