phpstan level 5

Author: xaviermarchegay

composer.json

@@ -57,7 +57,10 @@
   "require-dev": {
     "doctrine/doctrine-fixtures-bundle": "^3.4",
     "friendsofphp/php-cs-fixer": "^3.6",
+    "phpstan/extension-installer": "^1.1",
     "phpstan/phpstan": "^1",
+    "phpstan/phpstan-doctrine": "^1.2",
+    "phpstan/phpstan-symfony": "^1.1",
     "rector/rector": "^0.12.13",
     "roave/security-advisories": "dev-latest",
     "squizlabs/php_codesniffer": "^3.6",

phpstan.neon

@@ -1,6 +1,8 @@
 parameters:
-	level: 3
+	level: 5
 	paths:
 		- src
 	excludePaths:
 		- src/DependencyInjection/Configuration.php
+	ignoreErrors:
+		- '#is never written, only read#'

src/Controller/Crud/ProcessCrudController.php

@@ -64,7 +64,7 @@ public function configureFields(string $pageName): array
                     ProcessExecution::STATUS_FAIL => '<button class="btn btn-danger btn-lm">failed</button>',
                     ProcessExecution::STATUS_START => '<button class="btn btn-warning btn-lm">started</button>',
                     ProcessExecution::STATUS_SUCCESS => '<button class="btn btn-success btn-lm">success</button>',
-                    null => ''
+                    default => '<button class="btn btn-info btn-lm">unknown</button>',
                 };
             }),
         ];

src/Controller/Crud/ProcessExecutionCrudController.php

@@ -80,6 +80,7 @@ public function configureFields(string $pageName): array
                     ProcessExecution::STATUS_FAIL => '<button class="btn btn-danger btn-lm">failed</button>',
                     ProcessExecution::STATUS_START => '<button class="btn btn-warning btn-lm">started</button>',
                     ProcessExecution::STATUS_SUCCESS => '<button class="btn btn-success btn-lm">succcess</button>',
+                    default => '<button class="btn btn-info btn-lm">unknown</button>',
                 };
             }),
         ];

symfony.lock

@@ -139,9 +139,18 @@
     "php-cs-fixer/diff": {
         "version": "v2.0.2"
     },
+    "phpstan/extension-installer": {
+        "version": "1.1.0"
+    },
     "phpstan/phpstan": {
         "version": "0.12.89"
     },
+    "phpstan/phpstan-doctrine": {
+        "version": "1.2.10"
+    },
+    "phpstan/phpstan-symfony": {
+        "version": "1.1.5"
+    },
     "psr/cache": {
         "version": "1.0.1"
     },