#4 Remove DoctrineWriterTask option global_flush due to removing partially flush ability on doctrine/orm 3.* (https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#bc-break-removed-ability-to-partially-flushcommit-entity-manager-and-unit-of-work).

Author: njoubert-cleverage

CHANGELOG.md

@@ -3,12 +3,15 @@ v2.0
 
 ## BC breaks
 
-* [#6](https://github.com/cleverage/doctrine-process-bundle/issues/6) Update services according to Symfony best practices. Services should not use autowiring or autoconfiguration. Instead, all services should be defined explicitly.
+* [#6](https://github.com/cleverage/doctrine-process-bundle/issues/6) Update services according to Symfony best practices. 
+Services should not use autowiring or autoconfiguration. Instead, all services should be defined explicitly.
   Services must be prefixed with the bundle alias instead of using fully qualified class names => `cleverage_doctrine_process`
 * [#5](https://github.com/cleverage/doctrine-process-bundle/issues/5) Bump "doctrine/doctrine-bundle": "^2.5" according to Symfony versions supported by `cleverage/process-bundle`
 * [#4](https://github.com/cleverage/doctrine-process-bundle/issues/4) Allow installing "doctrine/orm": ^3.0 using at least require "doctrine/orm": "^2.9 || ^3.0".
 Forbid "doctrine/dbal" 4 for now (as on "symfony/orm-pack" - symfony/orm-pack@266bae0#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R7 ) using "doctrine/dbal": "^2.9 || ^3.0".
 Add "doctrine/common": "^3.0" and "doctrine/doctrine-migrations-bundle": "^3.2"
+* [#4](https://github.com/cleverage/doctrine-process-bundle/issues/4) Remove DoctrineWriterTask option `global_flush` 
+due to removing [partially flush ability](https://github.com/doctrine/orm/blob/3.0.x/UPGRADE.md#bc-break-removed-ability-to-partially-flushcommit-entity-manager-and-unit-of-work) on `doctrine/orm` 3.*
 
 
 ### Changes

docs/reference/tasks/doctrine_writer_task.md

@@ -24,5 +24,4 @@ Options
 | Code | Type | Required | Default | Description |
 | ---- | ---- | :------: | ------- | ----------- |
 | `entity_manager` | `string` or `null` | | `null` | Use another entity manager than the default |
-| `global_flush` | `bool` | | `true` | Flush the whole entity manager after persist |
 

src/Task/EntityManager/DoctrineReaderTask.php

@@ -17,7 +17,6 @@
 use CleverAge\ProcessBundle\Model\ProcessState;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
-use Doctrine\ORM\Internal\Hydration\IterableResult;
 use Doctrine\Persistence\ManagerRegistry;
 use Psr\Log\LoggerInterface;
 
@@ -26,7 +25,7 @@
  */
 class DoctrineReaderTask extends AbstractDoctrineQueryTask implements IterableTaskInterface
 {
-    protected ?IterableResult $iterator = null;
+    protected ?iterable $iterator = null;
 
     public function __construct(
         protected LoggerInterface $logger,
@@ -42,32 +41,29 @@ public function __construct(
      */
     public function next(ProcessState $state): bool
     {
-        if (!$this->iterator instanceof IterableResult) {
+        if (!is_iterable($this->iterator)) {
             return false;
         }
-        $this->iterator->next();
+        next($this->iterator);
 
-        return $this->iterator->valid();
+        return false !== current($this->iterator);
     }
 
     public function execute(ProcessState $state): void
     {
         $options = $this->getOptions($state);
-        if (!$this->iterator instanceof IterableResult) {
+        if (!is_iterable($this->iterator)) {
             /** @var class-string $class */
             $class = $options['class_name'];
             $entityManager = $this->doctrine->getManagerForClass($class);
             if (!$entityManager instanceof EntityManagerInterface) {
                 throw new \UnexpectedValueException("No manager found for class {$class}");
             }
             $repository = $entityManager->getRepository($class);
-            if (!$repository instanceof EntityRepository) {
-                throw new \UnexpectedValueException("No repository found for class {$class}");
-            }
             $this->initIterator($repository, $options);
         }
 
-        $result = $this->iterator->current();
+        $result = current($this->iterator);
 
         // Handle empty results
         if (false === $result) {
@@ -95,7 +91,7 @@ protected function initIterator(EntityRepository $repository, array $options): v
         );
 
         $this->iterator = $qb->getQuery()
-            ->iterate();
-        $this->iterator->next(); // Move to first element
+            ->toIterable();
+        next($this->iterator); // Move to first element
     }
 }

src/Task/EntityManager/DoctrineWriterTask.php

@@ -17,7 +17,6 @@
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityManagerInterface;
-use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
  * Persists and flush Doctrine entities.
@@ -29,18 +28,9 @@ public function execute(ProcessState $state): void
         $state->setOutput($this->writeEntity($state));
     }
 
-    protected function configureOptions(OptionsResolver $resolver): void
-    {
-        parent::configureOptions($resolver);
-        $resolver->setDefaults([
-            'global_flush' => true,
-        ]);
-        $resolver->setAllowedTypes('global_flush', ['boolean']);
-    }
-
     protected function writeEntity(ProcessState $state): mixed
     {
-        $options = $this->getOptions($state);
+        $this->getOptions($state);
         /** @var object $entity */
         $entity = $state->getInput();
 
@@ -55,11 +45,7 @@ protected function writeEntity(ProcessState $state): mixed
         }
         $entityManager->persist($entity);
 
-        if ($options['global_flush']) {
-            $entityManager->flush();
-        } else {
-            $entityManager->flush($entity);
-        }
+        $entityManager->flush();
 
         return $entity;
     }