Skip to content

Commit 7ea8f34

Browse files
author
Stephan Dilly
committed
update readme,changelog and rename logging arg (gitui-org#88)
1 parent f143f09 commit 7ea8f34

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88

99
### Added
1010
- support reverse tabbing using shift+tab ([#92](https://github.com/extrawurst/gitui/issues/92))
11+
- switch to using cmd line args instead of `ENV` (`-l` for logging and `--version`) **please convert your GITUI_LOGGING usage** [[@shenek](https://github.com/shenek)] ([#88](https://github.com/extrawurst/gitui/issues/88))
1112

1213
## [0.4.0] - 2020-05-25
1314

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
.PHONY: debug build-release release-linux-musl test clippy clippy-pedantic install install-debug
33

44
debug:
5-
GITUI_LOGGING=true cargo run --features=timing
5+
cargo run --features=timing -- -l
66

77
build-release:
88
cargo build --release

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ cargo install gitui
8888

8989
to enable logging:
9090
```
91-
GITUI_LOGGING=true gitui
91+
gitui -l
9292
```
9393

9494
this will log to:

src/main.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -227,16 +227,14 @@ fn process_cmdline() -> Result<()> {
227227
.version(crate_version!())
228228
.about(crate_description!())
229229
.arg(
230-
Arg::with_name("gitui-logging")
230+
Arg::with_name("logging")
231231
.help("Stores logging output into a cache directory")
232232
.short("l")
233-
.long("gitui-logging")
234-
.takes_value(false)
235-
.required(false),
233+
.long("logging"),
236234
);
237235

238236
let arg_matches = app.get_matches();
239-
if arg_matches.is_present("gitui-logging") {
237+
if arg_matches.is_present("logging") {
240238
setup_logging()?;
241239
}
242240

0 commit comments

Comments
 (0)