User: Account unification: add the possibility to filter on user status and the unification on a teacher account if one exist instead of the most recent account - refs BT#22702

Author: NicoDucou

main/inc/lib/myspace.lib.php

@@ -4583,18 +4583,22 @@ public static function duGetDuplicateValues(int $fieldId, int $urlId): array
     }
 
     /** Users having exactly a value for the given extra-field (filtered by portal). */
-    public static function duGetUsersByFieldValue(int $fieldId, int $urlId, string $value): array
+    public static function duGetUsersByFieldValue(int $fieldId, int $urlId, string $value, string $userStatusList = ''): array
     {
         $tblVals = Database::get_main_table(TABLE_EXTRA_FIELD_VALUES);
         $tblUser = Database::get_main_table(TABLE_MAIN_USER);
         $tblRel = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_USER);
         $valueSql = "'".Database::escape_string($value)."'";
-
+        $filterUserStatus = "";
+        if ($userStatusList != '') {
+            $filterUserStatus = "AND u.status in (".$userStatusList.")";
+        }
         $sql = "SELECT DISTINCT u.id AS user_id, u.username, u.firstname, u.lastname, u.email, u.registration_date
         FROM $tblUser u
         JOIN $tblRel  r ON r.user_id = u.id AND r.access_url_id = $urlId
         JOIN $tblVals v ON v.item_id = u.id AND v.field_id = $fieldId
         WHERE v.value = $valueSql
+        $filterUserStatus
         ORDER BY u.id ASC";
         $res = Database::query($sql);
 

tests/scripts/unify_duplicated_user_based_on_extra_field_value.php

@@ -5,6 +5,7 @@
 /**
  * This script takes a user extra field variabler and looks for users duplicated
  * based on this extra field values and unify them on the most recent account
+ * or the first teacher account if one has a teacher status/role
  */
 exit;
 $now = date('Y-m-d H:i:s');
@@ -30,6 +31,12 @@
     echo PHP_EOL;
 }
 
+// Filter user status to only search for user with those status
+// $filteredUserStatusList = "1,5";
+if (!empty($filteredUserStatusList)) {
+    echo "Filtered user status list is defined: " . $filteredUserStatusList . PHP_EOL;
+}
+
 // set the extra field variable to use
 $extraFieldVariable = 'dni';
 
@@ -63,12 +70,18 @@
                 echo "Value $value is in the filtered list. Proceeding..." . PHP_EOL;
             }
             echo 'Analysing duplicates of ' . $value . ' ...' . PHP_EOL;
-            $users = MySpace::duGetUsersByFieldValue($fieldId, $urlId, $value);
+            $users = MySpace::duGetUsersByFieldValue($fieldId, $urlId, $value, $filteredUserStatusList);
             $userIdToUnifyOn = 0;
             $mostRecentRegistrationDate = 0;
             foreach ($users as $u) {
                 $uid = (int)$u['user_id'];
                 $userInfo = api_get_user_info($uid);
+                // unify on the teacher account if exist
+                if ($userInfo['status'] == 1) {
+                    $userIdToUnifyOn = $uid;
+                    break;
+                }
+                // unify on the most recent account if none is teacher
                 if ($userInfo['registration_date'] > $mostRecentRegistrationDate) {
                     $mostRecentRegistrationDate = $userInfo['registration_date'];
                     $userIdToUnifyOn = $uid;