Security: Initialize variable to avoid wrong result by old value

AngelFQC · AngelFQC · commit c3afce072806 · 2025-05-26T18:31:20.000-05:00
See GHSA-qv5j-rq2p-q5w5
diff --git a/main/inc/ajax/model.ajax.php b/main/inc/ajax/model.ajax.php
@@ -143,6 +143,8 @@ function getWhereClause($col, $oper, $val)
 $accessEndDate = '';
 $overwriteColumnHeaderExport = [];
 
+$result = [];
+
 if (!empty($search)) {
     $search = 'true';
 }
@@ -215,7 +217,7 @@ function getWhereClause($col, $oper, $val)
                     }
                 }
 
-                $result = $extraField->getExtraFieldRules($filters, 'extra_');
+                $result = []; $extraField->getExtraFieldRules($filters, 'extra_');
 
                 $extra_fields = $result['extra_fields'];
                 $condition_array = $result['condition_array'];

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,8 @@ function getWhereClause($col, $oper, $val)`
`143`	`143`	`$accessEndDate = '';`
`144`	`144`	`$overwriteColumnHeaderExport = [];`
`145`	`145`
	`146`	`+$result = [];`
	`147`	`+`
`146`	`148`	`if (!empty($search)) {`
`147`	`149`	`$search = 'true';`
`148`	`150`	`}`
`@@ -215,7 +217,7 @@ function getWhereClause($col, $oper, $val)`
`215`	`217`	`}`
`216`	`218`	`}`
`217`	`219`
`218`		`- $result = $extraField->getExtraFieldRules($filters, 'extra_');`
	`220`	`+ $result = []; $extraField->getExtraFieldRules($filters, 'extra_');`
`219`	`221`
`220`	`222`	`$extra_fields = $result['extra_fields'];`
`221`	`223`	`$condition_array = $result['condition_array'];`