Internal: Fix psalm reports

Author: AngelFQC

src/CoreBundle/DataTransformer/SkillTreeNodeTransformer.php

@@ -16,7 +16,7 @@ public function __construct(
         private SettingsManager $settingsManager,
     ) {}
 
-    public function transform(Skill $object, string $to, array $context = []): SkillTreeNode
+    public function transform(Skill $object): SkillTreeNode
     {
         $skillNode = new SkillTreeNode();
         $skillNode->id = $object->getId();
@@ -32,7 +32,7 @@ public function transform(Skill $object, string $to, array $context = []): Skill
         }
 
         $skillNode->children = $object->getChildSkills()
-            ->map(fn (Skill $childSkill) => $this->transform($childSkill, $to, $context))
+            ->map(fn (Skill $childSkill) => $this->transform($childSkill))
             ->toArray()
         ;
 

src/CoreBundle/State/GroupMembersStateProvider.php

@@ -26,7 +26,7 @@ public function supports(Operation $operation, array $uriVariables = [], array $
         return Usergroup::class === $operation->getClass() && 'get_group_members' === $operation->getName();
     }
 
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []): iterable
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): array
     {
         $groupId = $uriVariables['id'] ?? null;
 

src/CoreBundle/State/MessageByGroupStateProvider.php

@@ -26,7 +26,7 @@ public function supports(Operation $operation, array $uriVariables = [], array $
         return Message::class === $operation->getClass() && 'get_messages_by_group' === $operation->getName();
     }
 
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []): iterable
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): array
     {
         $groupId = $context['filters']['groupId'] ?? null;
 

src/CoreBundle/State/PublicCatalogueCourseStateProvider.php

@@ -8,6 +8,7 @@
 
 use ApiPlatform\Metadata\Operation;
 use ApiPlatform\State\ProviderInterface;
+use Chamilo\CoreBundle\Entity\AccessUrl;
 use Chamilo\CoreBundle\Entity\Course;
 use Chamilo\CoreBundle\Entity\ExtraField;
 use Chamilo\CoreBundle\Repository\ExtraFieldValuesRepository;
@@ -17,6 +18,9 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
 
+/**
+ * @implements ProviderInterface<Course>
+ */
 readonly class PublicCatalogueCourseStateProvider implements ProviderInterface
 {
     public function __construct(
@@ -28,7 +32,7 @@ public function __construct(
         private TokenStorageInterface $tokenStorage
     ) {}
 
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []): array|object|null
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): array
     {
         $user = $this->tokenStorage->getToken()?->getUser();
         $isAuthenticated = \is_object($user);
@@ -49,12 +53,13 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
         }
 
         $host = $request->getSchemeAndHttpHost().'/';
+        /** @var AccessUrl $accessUrl */
         $accessUrl = $this->accessUrlRepository->findOneBy(['url' => $host]) ?? $this->accessUrlRepository->find(1);
         $courses = $this->courseRepository->createQueryBuilder('c')
             ->innerJoin('c.urls', 'url_rel')
             ->andWhere('url_rel.url = :accessUrl')
             ->andWhere('c.visibility IN (:visibilities)')
-            ->setParameter('accessUrl', $accessUrl)
+            ->setParameter('accessUrl', $accessUrl->getId())
             ->setParameter('visibilities', [Course::OPEN_WORLD, Course::OPEN_PLATFORM])
             ->orderBy('c.title', 'ASC')
             ->getQuery()

src/CoreBundle/State/UsergroupStateProvider.php

@@ -29,7 +29,7 @@ public function __construct(
     /**
      * @throws Exception
      */
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []): iterable
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): array
     {
         $operationName = $operation->getName();
         if ('get_usergroup' === $operationName) {